WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201996
[FTW] Enable WebKitTestRunner build
https://bugs.webkit.org/show_bug.cgi?id=201996
Summary
[FTW] Enable WebKitTestRunner build
Brent Fulgham
Reported
2019-09-19 12:21:47 PDT
It's time to get the test system up and running. This patch does the following: 1. Adds relevant CMake files to get things building. 2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
Attachments
Patch
(25.56 KB, patch)
2019-09-19 16:31 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2019-09-19 16:31:01 PDT
Created
attachment 379175
[details]
Patch
Brent Fulgham
Comment 2
2019-09-19 16:34:06 PDT
Comment on
attachment 379175
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=379175&action=review
> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877 > +#if USE(CF) && !PLATFORM(WIN_CAIRO) && !USE(DIRECT2D)
Maybe this should just be: #if USE(CF) && !OS(WINDOWS) ? This isn't build for the AppleWin port, either.
Brent Fulgham
Comment 3
2019-09-19 19:50:29 PDT
Note: These changes revealed
Bug 202021
.
WebKit Commit Bot
Comment 4
2019-09-19 21:56:02 PDT
Comment on
attachment 379175
[details]
Patch Clearing flags on attachment: 379175 Committed
r250121
: <
https://trac.webkit.org/changeset/250121
>
WebKit Commit Bot
Comment 5
2019-09-19 21:56:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-09-19 21:57:17 PDT
<
rdar://problem/55547688
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug