Bug 201996 - [FTW] Enable WebKitTestRunner build
Summary: [FTW] Enable WebKitTestRunner build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 161817
  Show dependency tree / graph
 
Reported: 2019-09-19 12:21 PDT by Brent Fulgham
Modified: 2019-09-19 21:57 PDT (History)
15 users (show)

See Also:

Attachments
Patch (25.56 KB, patch)
2019-09-19 16:31 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-09-19 12:21:47 PDT 
It's time to get the test system up and running. This patch does the following:

1. Adds relevant CMake files to get things building.
2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
Comment 1 Brent Fulgham 2019-09-19 16:31:01 PDT 
Created attachment 379175 [details]
Patch
Comment 2 Brent Fulgham 2019-09-19 16:34:06 PDT 
Comment on attachment 379175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379175&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> +#if USE(CF) && !PLATFORM(WIN_CAIRO) && !USE(DIRECT2D)

Maybe this should just be:

#if USE(CF) && !OS(WINDOWS) ? This isn't build for the AppleWin port, either.
Comment 3 Brent Fulgham 2019-09-19 19:50:29 PDT 
Note: These changes revealed Bug 202021.
Comment 4 WebKit Commit Bot 2019-09-19 21:56:02 PDT 
Comment on attachment 379175 [details]
Patch

Clearing flags on attachment: 379175

Committed r250121: <https://trac.webkit.org/changeset/250121>
Comment 5 WebKit Commit Bot 2019-09-19 21:56:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-19 21:57:17 PDT 
<rdar://problem/55547688>