Bug 201450 – [Win] Support Per-Monitor (V2) DPI Awareness

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Fujii Hironori]

[Win] Support Per-Monitor (V2) DPI Awareness

https://docs.microsoft.com/en-us/windows/win32/hidpi/high-dpi-desktop-application-development-on-windows

[Fujii Hironori]

Created attachment 377961 [details]
WIP patch

[Fujii Hironori]

Created attachment 377968 [details]
WIP patch

[Brent Fulgham]

Comment on attachment 377968 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377968&action=review

> Tools/MiniBrowser/win/WinMain.cpp:73
> +        ::SetProcessDPIAware();

It seems like we would need this change in the WebProcess, too.

[Fujii Hironori]

Comment on attachment 377968 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377968&action=review

>> Tools/MiniBrowser/win/WinMain.cpp:73
>> +        ::SetProcessDPIAware();
> 
> It seems like we would need this change in the WebProcess, too.

Web process doesn't use HWND at all at the moment (at least in WinCairo).
I will do it in Bug 201361 or Bug 186364.

[Fujii Hironori]

I need to replace following APIs, but it's not simple task because Web process doesn't know WebView's HWND at the moment.
GetSystemMetrics → GetSystemMetricsForDpi
SystemParametersInfo → SystemParametersInfoForDpi

I'll do that task in the follow-up patch.

[Fujii Hironori]

Created attachment 378040 [details]
Patch

[EWS Watchlist]

Comment on attachment 378040 [details]
Patch

Attachment 378040 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12998620

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html

[EWS Watchlist]

Created attachment 378042 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Fujii Hironori]

(In reply to Build Bot from comment #7)
> New failing tests:
> fast/block/float/float-with-anonymous-previous-sibling.html

This test is flaky on AppleWin.

Bug 194305 Comment 3
Bug 196717 Comment 8
Bug 198680 Comment 21

[Fujii Hironori]

Filed: Bug 201491 – [AppleWin] fast/block/float/float-with-anonymous-previous-sibling.html is failing as flaky ImageOnlyFailure

[Fujii Hironori]

Comment on attachment 378040 [details]
Patch

Clearing flags on attachment: 378040

Committed r249559: <https://trac.webkit.org/changeset/249559>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55095795>