Bug 198680 – Automate generation of computedProperties

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Devin Rousso]

AFAICT, there's no good reason why we don't generate the `computedProperties` list in CSSComputedStyleDeclaration.cpp from CSSProperties.json (or some other source).  I think we should migrate to a blacklist (take the full list of `CSSPropertyID` and remove those that aren't a longhand property) instead of a whitelist (what we have now, where it's a hardcoded list of items to include).

[Devin Rousso]

Created attachment 371670 [details]
Patch

[Devin Rousso]

Created attachment 371671 [details]
Old computedPropertyIDs

[Devin Rousso]

Created attachment 371672 [details]
New computedPropertyIDs

[Devin Rousso]

Created attachment 371673 [details]
Diff (ordered) of computedPropertyIDs

[Devin Rousso]

Created attachment 371674 [details]
Diff (alphabetized) of computedPropertyIDs

[Devin Rousso]

Created attachment 371675 [details]
Patch

[Devin Rousso]

Created attachment 371676 [details]
New computedPropertyIDs

[Devin Rousso]

Comment on attachment 371675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371675&action=review

> Source/WebCore/css/makeprop.pl:493
> +    my @longhands = @{$propertiesWithStyleBuilderOptions{$name}{"longhands"}};

Should we not skip properties that only have one longhand property?  This way, properties like `page-break-after` would also be shown with `break-after`.

[Devin Rousso]

Created attachment 371677 [details]
Patch

[Devin Rousso]

Comment on attachment 371677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371677&action=review

> Source/WebCore/css/makeprop.pl:493
> +    if (scalar @longhands != 1) {

Adding this causes the following to also be shown:
 - CSSPropertyAll
 - CSSPropertyPageBreakAfter
 - CSSPropertyPageBreakBefore
 - CSSPropertyPageBreakInside
 - CSSPropertyWebkitColumnBreakAfter
 - CSSPropertyWebkitColumnBreakBefore
 - CSSPropertyWebkitColumnBreakInside

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12421277

New failing tests:
svg/css/getComputedStyle-basic.xhtml
imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 371679 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12421293

New failing tests:
svg/css/getComputedStyle-basic.xhtml
imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 371680 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12421348

New failing tests:
svg/css/getComputedStyle-basic.xhtml
imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 371684 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12421377

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[EWS Watchlist]

Created attachment 371685 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12422118

New failing tests:
fast/shadow-dom/svg-text-path-href-change-in-shadow-tree.html
storage/indexeddb/index-cursor.html

[EWS Watchlist]

Created attachment 371698 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 371677 [details]
Patch

Attachment 371677 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12422959

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html

[EWS Watchlist]

Created attachment 371699 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Devin Rousso]

<rdar://problem/51507834>

[Devin Rousso]

Created attachment 371775 [details]
Patch

Getting the results from the bots -.-

[Joseph Pecoraro]

Comment on attachment 371775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371775&action=review

Seems fine.

> Source/WebCore/ChangeLog:9
> +        A property should be listed as part of a `CSSStyleâDeclarationâ` if:

Weird characters?

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-96
> -// List of all properties we know how to compute, omitting shorthands.
> -static const CSSPropertyID computedProperties[] = {

What is the diff between the old list and the new list? I assume touch-action, but did we add any others?

> Source/WebCore/css/makeprop.pl:487
> +print HEADER "static const CSSPropertyID computedPropertyIDs[] = {\n";
> +my $numComputedPropertyIDs = 0;
> +foreach my $name (@names) {

Should we sort this list? I think that would be convenient, it was semi-sorted before.

> Source/WebCore/css/makeprop.pl:491
> +  # Skip Shorthand properties if they have a non-internal longhand property.

Drop "Shorthand" and just say `Skip properties if they have a non-internal longhand property.`?

> Source/WebCore/css/makeprop.pl:509
> +  $numComputedPropertyIDs = $numComputedPropertyIDs + 1;

You can use ++ or just += in perl.

    $numComputedPropertyIDs += 1;

> LayoutTests/ChangeLog:9
> +        * imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements-expected.txt:

Ew, I wonder what this test is doing...

[EWS Watchlist]

Comment on attachment 371775 [details]
Patch

Attachment 371775 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12437710

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371787 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371775 [details]
Patch

Attachment 371775 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12437727

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371788 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371775 [details]
Patch

Attachment 371775 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12437781

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371791 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371775 [details]
Patch

Attachment 371775 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12437832

New failing tests:
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-style-2.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
fast/css/getComputedStyle/computed-style-font-family.html

[EWS Watchlist]

Created attachment 371794 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 371775 [details]
Patch

Attachment 371775 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12437960

New failing tests:
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/remove-underline-after-paragraph.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371795 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Devin Rousso]

Created attachment 371796 [details]
Patch

Alphabetize the enumerated values

[Devin Rousso]

Created attachment 371797 [details]
Patch

Rebase

[EWS Watchlist]

Comment on attachment 371797 [details]
Patch

Attachment 371797 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12439114

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371803 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371797 [details]
Patch

Attachment 371797 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12439479

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371807 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371797 [details]
Patch

Attachment 371797 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12439313

New failing tests:
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/toggle-style-2.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
fast/css/getComputedStyle/computed-style-font-family.html

[EWS Watchlist]

Created attachment 371808 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 371797 [details]
Patch

Attachment 371797 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12439453

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371810 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371797 [details]
Patch

Attachment 371797 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12439666

New failing tests:
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/remove-underline-after-paragraph.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371815 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Devin Rousso]

I've split the work for this into three separate bugs:
 - <https://webkit.org/b/198742> Include `touch-action` in the computed styles list
 - <https://webkit.org/b/198743> Sort the computed styles list
 - <https://webkit.org/b/198680> Automate generation of computedProperties

[Radar WebKit Bug Importer]

<rdar://problem/51611113>

[Devin Rousso]

Created attachment 371899 [details]
Patch

[Devin Rousso]

Created attachment 371901 [details]
computedPropertyIDs (after) (macOS)

[EWS Watchlist]

Comment on attachment 371899 [details]
Patch

Attachment 371899 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12449468

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371904 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371899 [details]
Patch

Attachment 371899 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12449548

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371907 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371899 [details]
Patch

Attachment 371899 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12449593

New failing tests:
editing/style/remove-underline-across-paragraph-in-bold.html
editing/style/text-decoration-state-change.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
fast/css/getComputedStyle/computed-style-font-family.html
editing/execCommand/toggle-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/toggle-style-2.html
editing/style/remove-underline-across-paragraph.html
editing/style/remove-underline.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/toggle-styles.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/style/remove-underline-in-bold.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371910 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371899 [details]
Patch

Attachment 371899 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12449547

New failing tests:
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-style-2.html
fast/css/getComputedStyle/computed-style-without-renderer.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html
fast/css/getComputedStyle/computed-style-font-family.html

[EWS Watchlist]

Created attachment 371911 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 371899 [details]
Patch

Attachment 371899 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12449689

New failing tests:
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/remove-underline-after-paragraph.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/push-down-implicit-styles-mac.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371913 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Devin Rousso]

Created attachment 371916 [details]
Patch

Check non-editing tests

[EWS Watchlist]

Comment on attachment 371916 [details]
Patch

Attachment 371916 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12450759

New failing tests:
editing/style/remove-underline-in-bold.html
editing/style/remove-underline-across-paragraph.html
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/style/remove-underline.html
editing/style/remove-underline-across-paragraph-in-bold.html
editing/execCommand/toggle-style-2.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-mac.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371926 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371916 [details]
Patch

Attachment 371916 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12450767

New failing tests:
editing/style/remove-underline-in-bold.html
editing/style/remove-underline-across-paragraph.html
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/style/remove-underline.html
editing/style/remove-underline-across-paragraph-in-bold.html
editing/execCommand/toggle-style-2.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-mac.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371927 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371916 [details]
Patch

Attachment 371916 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12450788

New failing tests:
editing/style/remove-underline-in-bold.html
editing/style/remove-underline-across-paragraph.html
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/style/remove-underline.html
editing/style/remove-underline-across-paragraph-in-bold.html
editing/execCommand/toggle-style-2.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/push-down-implicit-styles-mac.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/style/remove-underline-after-paragraph.html
editing/execCommand/query-command-state.html

[EWS Watchlist]

Created attachment 371928 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 371916 [details]
Patch

Attachment 371916 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12450872

New failing tests:
editing/execCommand/toggle-styles.html
editing/style/text-decoration-state-change.html
editing/execCommand/query-text-decoration-with-typing-style.html
editing/style/text-decoration-state.html
editing/style/remove-underline-after-paragraph-in-bold.html
editing/execCommand/toggle-style-2.html
editing/execCommand/toggle-text-decorations.html
editing/execCommand/merge-text-decoration-with-typing-style.html
editing/style/remove-nested-inline-styles.html
editing/style/push-down-inline-styles.html
editing/execCommand/strikethroughSelection.html
editing/execCommand/toggle-mixed-text-decorations.html
editing/style/remove-underline-after-paragraph.html

[EWS Watchlist]

Created attachment 371931 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Devin Rousso]

Created attachment 371975 [details]
CSSComputedStyleDeclaration.cpp.diff (macOS)

[Devin Rousso]

Created attachment 371977 [details]
Patch

Turns out we need to include `-webkit-text-decorations-in-effect` as it's used all over editing code :(

[Devin Rousso]

Created attachment 372101 [details]
Patch

[Devin Rousso]

Created attachment 381834 [details]
Patch

Rebase

[WebKit Commit Bot]

Comment on attachment 381834 [details]
Patch

Clearing flags on attachment: 381834

Committed r251581: <https://trac.webkit.org/changeset/251581>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antti Koivisto]

Nice!