Bug 203943 - Remove unimplemented property error log in when getting a property value from a computed style
Summary: Remove unimplemented property error log in when getting a property value from...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 198680
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-06 21:59 PST by Devin Rousso
Modified: 2019-11-06 23:22 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.87 KB, patch)
2019-11-06 22:04 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-11-06 21:59:38 PST
In r251581, the list of computed CSS properties was changed to be autogenerated from 'CSSProperties.json'.  One issue that arose from this was that `-webkit-text-decorations-in-effect` was no longer part of the `CSSComputedStyleDeclaration`, which caused a number of editing tests to fail, as that property is used for holding internal state related to various editing commands (e.g. `document.execCommand`).  In order to get around this, `ComputedStyleExtractor::copyProperties()` was modified to instead copy _all_ CSS properties, regardless of whether they're part of the set of computed CSS properties.  Unfortunately, this had a side effect of triggering a longstanding `LOG_ERROR` (added in r6178) when attempting to retrieve the value of certain CSS properties (e.g. `-internal-text-autosizing-status`).  Since this path can be triggered by any arbitrary JavaScript (e.g. `window.getComputedStyle(document.body).getPropertyCSSValue("-internal-text-autosizing-status")`), it doesn't add much benefit to have this log, especially since the code itself is already annotated with comments/FIXMEs for CSS properties that don't have a computed value.
Comment 1 Devin Rousso 2019-11-06 22:04:24 PST
Created attachment 383023 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-06 23:21:44 PST
Comment on attachment 383023 [details]
Patch

Clearing flags on attachment: 383023

Committed r252176: <https://trac.webkit.org/changeset/252176>
Comment 3 WebKit Commit Bot 2019-11-06 23:21:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-06 23:22:16 PST
<rdar://problem/56973391>