Bug 198743 - Sort the computed styles list
Summary: Sort the computed styles list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 198742
Blocks: 198680
  Show dependency treegraph
 
Reported: 2019-06-10 22:13 PDT by Devin Rousso
Modified: 2019-06-11 16:32 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.82 KB, patch)
2019-06-10 22:46 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.24 MB, application/zip)
2019-06-10 23:52 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (3.02 MB, application/zip)
2019-06-11 00:02 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.69 MB, application/zip)
2019-06-11 00:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (3.12 MB, application/zip)
2019-06-11 01:20 PDT, Build Bot
no flags Details
Patch (534.31 KB, patch)
2019-06-11 10:00 PDT, Devin Rousso
simon.fraser: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.16 MB, application/zip)
2019-06-11 11:08 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.00 MB, application/zip)
2019-06-11 11:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (2.97 MB, application/zip)
2019-06-11 11:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.56 MB, application/zip)
2019-06-11 11:56 PDT, Build Bot
no flags Details
Patch (512.58 KB, patch)
2019-06-11 12:56 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (509.44 KB, patch)
2019-06-11 12:58 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (506.36 KB, patch)
2019-06-11 12:59 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (503.35 KB, patch)
2019-06-11 13:02 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (487.09 KB, patch)
2019-06-11 14:02 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (487.09 KB, patch)
2019-06-11 14:47 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (488.70 KB, patch)
2019-06-11 14:59 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-10 22:13:10 PDT
The current ordering of the list is based on the order of properties in CSSProperties.json, which is to say "totally arbitrary".  The spec doesn't seem to indicate anything about how these values should be ordered, and other browsers have varying functionality.

In order to make it easier to find regressions for <https://webkit.org/b/198680>, we should sort the computed properties list.
Comment 1 Devin Rousso 2019-06-10 22:46:11 PDT
Created attachment 371825 [details]
Patch
Comment 2 Devin Rousso 2019-06-10 22:47:27 PDT
Comment on attachment 371825 [details]
Patch

This will need to be rebased once <https://webkit.org/b/198742> lands.
Comment 3 Radar WebKit Bug Importer 2019-06-10 22:49:32 PDT
<rdar://problem/51611114>
Comment 4 Build Bot 2019-06-10 23:52:36 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2019-06-10 23:52:38 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2019-06-11 00:02:32 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2019-06-11 00:02:34 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2019-06-11 00:41:19 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2019-06-11 00:41:21 PDT Comment hidden (obsolete)
Comment 10 Build Bot 2019-06-11 01:20:49 PDT Comment hidden (obsolete)
Comment 11 Build Bot 2019-06-11 01:20:50 PDT Comment hidden (obsolete)
Comment 12 Devin Rousso 2019-06-11 10:00:29 PDT
Created attachment 371850 [details]
Patch

I sorted all of the test results manually, and I didn't add/remove any lines, so the contents are the exact same, just in a different order :P
Comment 13 Build Bot 2019-06-11 11:08:07 PDT Comment hidden (obsolete)
Comment 14 Build Bot 2019-06-11 11:08:08 PDT Comment hidden (obsolete)
Comment 15 Build Bot 2019-06-11 11:15:48 PDT Comment hidden (obsolete)
Comment 16 Build Bot 2019-06-11 11:15:51 PDT Comment hidden (obsolete)
Comment 17 Build Bot 2019-06-11 11:48:27 PDT Comment hidden (obsolete)
Comment 18 Build Bot 2019-06-11 11:48:28 PDT Comment hidden (obsolete)
Comment 19 Build Bot 2019-06-11 11:56:17 PDT Comment hidden (obsolete)
Comment 20 Build Bot 2019-06-11 11:56:18 PDT Comment hidden (obsolete)
Comment 21 Devin Rousso 2019-06-11 12:56:41 PDT
Created attachment 371866 [details]
Patch
Comment 22 Devin Rousso 2019-06-11 12:58:10 PDT
Created attachment 371867 [details]
Patch
Comment 23 Devin Rousso 2019-06-11 12:59:32 PDT
Created attachment 371869 [details]
Patch
Comment 24 Devin Rousso 2019-06-11 13:02:24 PDT
Created attachment 371870 [details]
Patch
Comment 25 Devin Rousso 2019-06-11 14:02:07 PDT
Created attachment 371876 [details]
Patch
Comment 26 Devin Rousso 2019-06-11 14:47:08 PDT
Created attachment 371880 [details]
Patch
Comment 27 Devin Rousso 2019-06-11 14:59:48 PDT
Created attachment 371882 [details]
Patch
Comment 28 WebKit Commit Bot 2019-06-11 16:32:54 PDT
Comment on attachment 371882 [details]
Patch

Clearing flags on attachment: 371882

Committed r246339: <https://trac.webkit.org/changeset/246339>
Comment 29 WebKit Commit Bot 2019-06-11 16:32:56 PDT
All reviewed patches have been landed.  Closing bug.