198743 – Sort the computed styles list

RESOLVED FIXED 198743

Sort the computed styles list

https://bugs.webkit.org/show_bug.cgi?id=198743

Summary Sort the computed styles list

Devin Rousso

Reported 2019-06-10 22:13:10 PDT

The current ordering of the list is based on the order of properties in CSSProperties.json, which is to say "totally arbitrary". The spec doesn't seem to indicate anything about how these values should be ordered, and other browsers have varying functionality. In order to make it easier to find regressions for <https://webkit.org/b/198680>, we should sort the computed properties list.

Attachments
Patch (14.82 KB, patch) 2019-06-10 22:46 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.24 MB, application/zip) 2019-06-10 23:52 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (3.02 MB, application/zip) 2019-06-11 00:02 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.69 MB, application/zip) 2019-06-11 00:41 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (3.12 MB, application/zip) 2019-06-11 01:20 PDT, EWS Watchlist	no flags	Details
Patch (534.31 KB, patch) 2019-06-11 10:00 PDT, Devin Rousso	simon.fraser: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.16 MB, application/zip) 2019-06-11 11:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.00 MB, application/zip) 2019-06-11 11:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (2.97 MB, application/zip) 2019-06-11 11:48 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.56 MB, application/zip) 2019-06-11 11:56 PDT, EWS Watchlist	no flags	Details
Patch (512.58 KB, patch) 2019-06-11 12:56 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (509.44 KB, patch) 2019-06-11 12:58 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (506.36 KB, patch) 2019-06-11 12:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (503.35 KB, patch) 2019-06-11 13:02 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (487.09 KB, patch) 2019-06-11 14:02 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (487.09 KB, patch) 2019-06-11 14:47 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (488.70 KB, patch) 2019-06-11 14:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-06-10 22:46:11 PDT

Created attachment 371825 [details] Patch

Devin Rousso

Comment 2 2019-06-10 22:47:27 PDT

Comment on attachment 371825 [details] Patch This will need to be rebased once <https://webkit.org/b/198742> lands.

Radar WebKit Bug Importer

Comment 3 2019-06-10 22:49:32 PDT

<rdar://problem/51611114>

EWS Watchlist

Comment 4 2019-06-10 23:52:36 PDT Comment hidden (obsolete)

Comment on attachment 371825 [details] Patch Attachment 371825 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12441256 New failing tests: svg/css/getComputedStyle-basic.xhtml imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html fast/css/getComputedStyle/computed-style-without-renderer.html

EWS Watchlist

Comment 5 2019-06-10 23:52:38 PDT Comment hidden (obsolete)

Created attachment 371827 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-06-11 00:02:32 PDT Comment hidden (obsolete)

Comment on attachment 371825 [details] Patch Attachment 371825 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12441268 New failing tests: svg/css/getComputedStyle-basic.xhtml imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html fast/css/getComputedStyle/computed-style-without-renderer.html

EWS Watchlist

Comment 7 2019-06-11 00:02:34 PDT Comment hidden (obsolete)

Created attachment 371828 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-06-11 00:41:19 PDT Comment hidden (obsolete)

Comment on attachment 371825 [details] Patch Attachment 371825 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12441297 New failing tests: fast/css/getComputedStyle/computed-style-without-renderer.html imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html svg/css/getComputedStyle-basic.xhtml

EWS Watchlist

Comment 9 2019-06-11 00:41:21 PDT Comment hidden (obsolete)

Created attachment 371829 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

EWS Watchlist

Comment 10 2019-06-11 01:20:49 PDT Comment hidden (obsolete)

Comment on attachment 371825 [details] Patch Attachment 371825 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12441510 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html fast/css/getComputedStyle/computed-style-without-renderer.html

EWS Watchlist

Comment 11 2019-06-11 01:20:50 PDT Comment hidden (obsolete)

Created attachment 371831 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 12 2019-06-11 10:00:29 PDT

Created attachment 371850 [details] Patch I sorted all of the test results manually, and I didn't add/remove any lines, so the contents are the exact same, just in a different order :P

EWS Watchlist

Comment 13 2019-06-11 11:08:07 PDT Comment hidden (obsolete)

Comment on attachment 371850 [details] Patch Attachment 371850 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12445181 New failing tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html svg/css/getComputedStyle-basic.xhtml

EWS Watchlist

Comment 14 2019-06-11 11:08:08 PDT Comment hidden (obsolete)

Created attachment 371856 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 15 2019-06-11 11:15:48 PDT Comment hidden (obsolete)

Comment on attachment 371850 [details] Patch Attachment 371850 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12445190 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style-font-family.html accessibility/img-alt-attribute-no-value.html

EWS Watchlist

Comment 16 2019-06-11 11:15:51 PDT Comment hidden (obsolete)

Created attachment 371858 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 17 2019-06-11 11:48:27 PDT Comment hidden (obsolete)

Comment on attachment 371850 [details] Patch Attachment 371850 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12445323 New failing tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html svg/css/getComputedStyle-basic.xhtml

EWS Watchlist

Comment 18 2019-06-11 11:48:28 PDT Comment hidden (obsolete)

Created attachment 371860 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 19 2019-06-11 11:56:17 PDT Comment hidden (obsolete)

Comment on attachment 371850 [details] Patch Attachment 371850 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12445339 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html fast/css/getComputedStyle/computed-style-without-renderer.html

EWS Watchlist

Comment 20 2019-06-11 11:56:18 PDT Comment hidden (obsolete)

Created attachment 371861 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Devin Rousso

Comment 21 2019-06-11 12:56:41 PDT

Created attachment 371866 [details] Patch

Devin Rousso

Comment 22 2019-06-11 12:58:10 PDT

Created attachment 371867 [details] Patch

Devin Rousso

Comment 23 2019-06-11 12:59:32 PDT

Created attachment 371869 [details] Patch

Devin Rousso

Comment 24 2019-06-11 13:02:24 PDT

Created attachment 371870 [details] Patch

Devin Rousso

Comment 25 2019-06-11 14:02:07 PDT

Created attachment 371876 [details] Patch

Devin Rousso

Comment 26 2019-06-11 14:47:08 PDT

Created attachment 371880 [details] Patch

Devin Rousso

Comment 27 2019-06-11 14:59:48 PDT

Created attachment 371882 [details] Patch

WebKit Commit Bot

Comment 28 2019-06-11 16:32:54 PDT

Comment on attachment 371882 [details] Patch Clearing flags on attachment: 371882 Committed r246339: <https://trac.webkit.org/changeset/246339>

WebKit Commit Bot

Comment 29 2019-06-11 16:32:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Devin Rousso

Reported

2019-06-10 22:13 PDT

Modified

2019-06-11 16:32 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

198742

Blocks

198680

Dependencies

tree graph