Bug 196717 - [CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory
Summary: [CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-08 17:58 PDT by Don Olmstead
Modified: 2020-04-23 13:08 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.30 KB, patch)
2019-05-30 23:03 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (6.00 KB, patch)
2019-05-30 23:35 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (7.83 KB, patch)
2019-05-30 23:54 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2019-05-31 06:31 PDT, Don Olmstead 		annulen: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-highsierra (2.91 MB, application/zip)
2019-05-31 08:18 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews215 for win-future (13.64 MB, application/zip)
2019-05-31 10:02 PDT, EWS Watchlist 		no flags Details
WIP Patch (3.00 KB, patch)
2020-04-23 11:19 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2020-04-23 12:01 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-08 17:58:23 PDT 
Currently ${CMAKE_BINARY_DIR} is a public include of WTF so it ends up being propagated to all targets dependent on it.
Comment 1 Don Olmstead 2019-05-30 23:03:07 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2019-05-30 23:35:45 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2019-05-30 23:54:14 PDT 
Created attachment 371040 [details]
Patch
Comment 4 Don Olmstead 2019-05-31 06:31:12 PDT 
Created attachment 371054 [details]
Patch
Comment 5 Konstantin Tokarev 2019-05-31 06:46:35 PDT 
Comment on attachment 371054 [details]
Patch

r=me if EWS is happy
Comment 6 EWS Watchlist 2019-05-31 08:18:30 PDT 
Comment on attachment 371054 [details]
Patch

Attachment 371054 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12339576

New failing tests:
webgl/2.0.0/conformance/textures/misc/origin-clean-conformance.html
Comment 7 EWS Watchlist 2019-05-31 08:18:32 PDT 
Created attachment 371057 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-05-31 10:02:51 PDT 
Comment on attachment 371054 [details]
Patch

Attachment 371054 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12340114

New failing tests:
fast/block/float/float-with-anonymous-previous-sibling.html
Comment 9 EWS Watchlist 2019-05-31 10:02:53 PDT 
Created attachment 371067 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 10 Don Olmstead 2020-04-23 11:19:29 PDT 
Created attachment 397364 [details]
WIP Patch
Comment 11 Don Olmstead 2020-04-23 12:01:58 PDT 
Created attachment 397370 [details]
Patch
Comment 12 EWS 2020-04-23 13:08:53 PDT 
Committed r260593: <https://trac.webkit.org/changeset/260593>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397370 [details].