RESOLVED FIXED Bug 196717
[CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory 
https://bugs.webkit.org/show_bug.cgi?id=196717
Summary [CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory
Don Olmstead
Reported 2019-04-08 17:58:23 PDT
Currently ${CMAKE_BINARY_DIR} is a public include of WTF so it ends up being propagated to all targets dependent on it.
Attachments
Patch (5.30 KB, patch)
2019-05-30 23:03 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2019-05-30 23:35 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.83 KB, patch)
2019-05-30 23:54 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2019-05-31 06:31 PDT, Don Olmstead 		annulen: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-highsierra (2.91 MB, application/zip)
2019-05-31 08:18 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews215 for win-future (13.64 MB, application/zip)
2019-05-31 10:02 PDT, EWS Watchlist 		no flags
Details
WIP Patch (3.00 KB, patch)
2020-04-23 11:19 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (4.77 KB, patch)
2020-04-23 12:01 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-05-30 23:03:07 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2019-05-30 23:35:45 PDT Comment hidden (obsolete)
Don Olmstead
Comment 3 2019-05-30 23:54:14 PDT
Created attachment 371040 [details] Patch
Don Olmstead
Comment 4 2019-05-31 06:31:12 PDT
Created attachment 371054 [details] Patch
Konstantin Tokarev
Comment 5 2019-05-31 06:46:35 PDT
Comment on attachment 371054 [details] Patch r=me if EWS is happy
EWS Watchlist
Comment 6 2019-05-31 08:18:30 PDT
Comment on attachment 371054 [details] Patch Attachment 371054 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12339576 New failing tests: webgl/2.0.0/conformance/textures/misc/origin-clean-conformance.html
EWS Watchlist
Comment 7 2019-05-31 08:18:32 PDT
Created attachment 371057 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 8 2019-05-31 10:02:51 PDT
Comment on attachment 371054 [details] Patch Attachment 371054 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12340114 New failing tests: fast/block/float/float-with-anonymous-previous-sibling.html
EWS Watchlist
Comment 9 2019-05-31 10:02:53 PDT
Created attachment 371067 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Don Olmstead
Comment 10 2020-04-23 11:19:29 PDT
Created attachment 397364 [details] WIP Patch
Don Olmstead
Comment 11 2020-04-23 12:01:58 PDT
Created attachment 397370 [details] Patch
EWS
Comment 12 2020-04-23 13:08:53 PDT
Committed r260593: <https://trac.webkit.org/changeset/260593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397370 [details].
Note You need to log in before you can comment on or make changes to this bug.