Bug 201308 - [ews-app] Status bubble should only display important messages in pop-over
Summary: [ews-app] Status bubble should only display important messages in pop-over
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-29 13:13 PDT by Aakash Jain
Modified: 2020-03-10 09:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2019-08-29 13:16 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff
Change in builder steps display (376.21 KB, image/png)
2019-08-29 13:19 PDT, Aakash Jain
no flags Details
Change in tester steps display (414.61 KB, image/png)
2019-08-29 13:20 PDT, Aakash Jain
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-08-29 13:13:36 PDT
currently status bubble pop-over displays almost all the build steps. Most of the time, users look at the pop-over to get a quick idea about the current state of the patch, rather than to know each and every past steps. To look at the details, they can click the bubble. 

Pop-over should contain concise text to indicate the major information about the state of the patch. Minor steps like 'Archived test results', 'Uploaded test results'  etc. shouldn't be displayed in the status-bubble.
Comment 1 Aakash Jain 2019-08-29 13:16:28 PDT
Created attachment 377614 [details]
Patch
Comment 2 Aakash Jain 2019-08-29 13:19:50 PDT
Created attachment 377615 [details]
Change in builder steps display
Comment 3 Aakash Jain 2019-08-29 13:20:28 PDT
Created attachment 377616 [details]
Change in tester steps display
Comment 4 Jonathan Bedard 2019-08-29 13:27:19 PDT
Comment on attachment 377614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377614&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:56
> +    STEPS_TO_HIDE = ['^Archived built product$', '^Uploaded built product$', '^Transferred archive to S3$',

My only question is: should this be inverted? As in 'STEPS_TO_SHOW'?
Comment 5 Aakash Jain 2019-08-29 13:59:48 PDT
> My only question is: should this be inverted? As in 'STEPS_TO_SHOW'?
Maintaining whitelist would be more difficult in long run, as we add more and more steps.

Consequences for missing something from blacklist is small (extra step being displayed). But consequence of missing something from whitelist will be larger (important step not visible).
Comment 6 Aakash Jain 2019-08-29 14:55:14 PDT
Committed r249294: <https://trac.webkit.org/changeset/249294>
Comment 7 Radar WebKit Bug Importer 2019-08-29 14:56:21 PDT
<rdar://problem/54856029>