Bug 201308 – [ews-app] Status bubble should only display important messages in pop-over

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

currently status bubble pop-over displays almost all the build steps. Most of the time, users look at the pop-over to get a quick idea about the current state of the patch, rather than to know each and every past steps. To look at the details, they can click the bubble. 

Pop-over should contain concise text to indicate the major information about the state of the patch. Minor steps like 'Archived test results', 'Uploaded test results'  etc. shouldn't be displayed in the status-bubble.

[Aakash Jain]

Created attachment 377614 [details]
Patch

[Aakash Jain]

Created attachment 377615 [details]
Change in builder steps display

[Aakash Jain]

Created attachment 377616 [details]
Change in tester steps display

[Jonathan Bedard]

Comment on attachment 377614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377614&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:56
> +    STEPS_TO_HIDE = ['^Archived built product$', '^Uploaded built product$', '^Transferred archive to S3$',

My only question is: should this be inverted? As in 'STEPS_TO_SHOW'?

[Aakash Jain]

> My only question is: should this be inverted? As in 'STEPS_TO_SHOW'?
Maintaining whitelist would be more difficult in long run, as we add more and more steps.

Consequences for missing something from blacklist is small (extra step being displayed). But consequence of missing something from whitelist will be larger (important step not visible).

[Aakash Jain]

Committed r249294: <https://trac.webkit.org/changeset/249294>

[Radar WebKit Bug Importer]

<rdar://problem/54856029>