Bug 196584 – [ews-app] Status bubble should not display skipped buildbot steps

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Created attachment 366681 [details]
Screenshot without the fix

[ews-app] Status bubble should not display skipped buildbot steps. Since these steps were not run (in buildbot build), these shouldn't be displayed in the status-bubble hover-over message.

For example in attached screenshot 'Unapplied patch (skipped)' and 'Compile Webkit (skipped)' should not be shown in status-bubble, since these steps were not run by Buildbot.

[Aakash Jain]

Created attachment 366682 [details]
Patch

[Jonathan Bedard]

Comment on attachment 366682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366682&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:44
> +    STEPS_TO_HIDE = ['Killed old processes', 'Configured build', '^OS:.*Xcode:', '(skipped)']

...I'm not sure this is actually what we want. It makes sense if some clean-up steps get squashed, but what happens if we skip something like API tests or layout tests? Would that even be possible?

[Aakash Jain]

> ...I'm not sure this is actually what we want. It makes sense if some
> clean-up steps get squashed, but what happens if we skip something like API
> tests or layout tests? Would that even be possible?
I don't see a scenario when buildbot would skip the step (based on doStepIf) and we want to intentionally show it in status-bubble. 

We have '(skipped)' in the step state_string when buildbot skips the step (usually based on doStepIf). For e.g.: in this case we have step to Unapply patch, this step is present in almost all builds and is usually skipped, it is run based on doStepIf (when the compilation fails). Displaying the status 'Unapplied Patch (skipped)' would be pretty confusing for the user.

We don't have doStepIf in crucial steps like API tests or layout tests, so these shouldn't be skipped.

[WebKit Commit Bot]

Comment on attachment 366682 [details]
Patch

Clearing flags on attachment: 366682

Committed r243897: <https://trac.webkit.org/changeset/243897>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49620520>