Bug 196550 - [ews-app] Status bubble should not display certain infrastructure status messages
Summary: [ews-app] Status bubble should not display certain infrastructure status mess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 11:56 PDT by Aakash Jain
Modified: 2021-04-26 14:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2019-04-03 12:06 PDT, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-03 11:56:31 PDT 
[ews-app] Status bubble should not display certain infrastructure status messages, e.g.: There is no need to display 'Killed old processes' or 'Configured build' in the status-bubble hover over message.
Comment 1 Aakash Jain 2019-04-03 12:06:52 PDT 
Created attachment 366627 [details]
Patch
Comment 2 Lucas Forschler 2019-04-03 12:58:38 PDT 
Comment on attachment 366627 [details]
Patch

This looks fine to me...but I'm not sure why we need to hide the steps? Can you add more information to change log about why we would want to hide these? Are they ugly? un-needed? does hiding them make it harder to debug?
Comment 3 Aakash Jain 2019-04-03 13:27:15 PDT 
Committed r243823: <https://trac.webkit.org/changeset/243823>
Comment 4 Radar WebKit Bug Importer 2019-04-03 13:28:21 PDT 
<rdar://problem/49570722>
Comment 5 Aakash Jain 2019-04-03 13:30:17 PDT 
> This looks fine to me...but I'm not sure why we need to hide the steps? Can
> you add more information to change log about why we would want to hide
> these? Are they ugly? un-needed? does hiding them make it harder to debug?
Updated ChangeLog before landing. They are simply un-needed from end user perspective. This information is still available in the Buildbot build page, if the user click on the status-bubble.