Bug 201294 - Flaky Test: svg/custom/tabindex-order.html
Summary: Flaky Test: svg/custom/tabindex-order.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 50856
  Show dependency treegraph
 
Reported: 2019-08-29 01:23 PDT by WebKit Commit Bot
Modified: 2019-08-29 20:00 PDT (History)
8 users (show)

See Also:


Attachments
Archive of layout-test-results from webkit-cq-01 (3.19 MB, application/zip)
2019-08-29 01:23 PDT, WebKit Commit Bot
no flags Details
Fixes the test again (1.72 KB, patch)
2019-08-29 14:29 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2019-08-29 01:23:42 PDT
This is an automatically generated bug from the commit-queue.
svg/custom/tabindex-order.html has been flaky on the commit-queue.

svg/custom/tabindex-order.html was authored by krit@webkit.org and rniwa@webkit.org.
https://trac.webkit.org/browser/trunk/LayoutTests/svg/custom/tabindex-order.html

The commit-queue just saw svg/custom/tabindex-order.html flake (text diff) while processing attachment 377554 [details] on bug 201290.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.
Comment 1 WebKit Commit Bot 2019-08-29 01:23:43 PDT
Created attachment 377560 [details]
Archive of layout-test-results from webkit-cq-01
Comment 2 Ryan Haddad 2019-08-29 12:11:01 PDT
This was caused by https://trac.webkit.org/changeset/249237/webkit

--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/svg/custom/tabindex-order-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/svg/custom/tabindex-order-actual.txt
@@ -32,7 +32,6 @@
 id: c tabindex: 1 [object SVGEllipseElement] is focused.
 id: b tabindex: 1 [object SVGGElement] is focused.
 id: a tabindex: 1 [object SVGCircleElement] is focused.
-id: k tabindex: 0 [object SVGPolygonElement] is focused.
 
 Test finished
Comment 3 Ryosuke Niwa 2019-08-29 13:19:29 PDT
Hm... I can't reproduce the flakiness either in debug or release on 10.14 but maybe I need 10.13. The flakiness dashboard suggests this:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=svg%2Fcustom%2Ftabindex-order.html
Comment 4 Ryosuke Niwa 2019-08-29 13:37:33 PDT
Alright, building on 10.13 now...
Comment 5 Ryosuke Niwa 2019-08-29 14:19:07 PDT
Hm... I can't reproduce this on high sierra with debt builds either.
Comment 6 Ryosuke Niwa 2019-08-29 14:29:16 PDT
Created attachment 377625 [details]
Fixes the test again
Comment 7 Ryosuke Niwa 2019-08-29 14:51:24 PDT
Committed r249293: <https://trac.webkit.org/changeset/249293>
Comment 8 Radar WebKit Bug Importer 2019-08-29 14:52:20 PDT
<rdar://problem/54855749>