Bug 201290 – Web Inspector: Import file pickers sometimes do not import

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Import file pickers sometimes do not import

Steps to Reproduce:
1. Inspect webkit.org
2. Show Timeline tab
3. Click "Import" button
4. Select a previously exported recording
  => Nothing happens

Notes:
• FileChooser::invalidate happened because the input element got GC'd => "change" handler never fired

Lets keep the <input type="file"> around artificially.

[Radar WebKit Bug Importer]

<rdar://problem/54826117>

[Joseph Pecoraro]

Created attachment 377549 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 377549 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=377549&action=review

r=me, nice catch!  Really odd that an active input can get GC'd 🤔

> Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:91
> +        fileReader.readAsDataURL(saveData.content);

Nice!

> Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:96
> +        if (!FileUtilities.importTextInputElement) {

Could we use an "_" prefixed value to make sure callers know it's private?  Just like `WI.ImageUtilities._scratchContext2D`.

> Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:111
> +        if (!FileUtilities.importJSONInputElement) {

Do we need a separate <input> for text vs json?  Theoretically, only one can be active at a time, so it shouldn't be an issue.

> Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:135
>              let reader = new FileReader;

You could also move this inside the `Promise` as well, as it's not needed anywhere outside.

[Joseph Pecoraro]

> > Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:96
> > +        if (!FileUtilities.importTextInputElement) {
> 
> Could we use an "_" prefixed value to make sure callers know it's private? 
> Just like `WI.ImageUtilities._scratchContext2D`.

Sure.

> > Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:111
> > +        if (!FileUtilities.importJSONInputElement) {
> 
> Do we need a separate <input> for text vs json?  Theoretically, only one can
> be active at a time, so it shouldn't be an issue.

Let's keep it separate. If the other bug gets addressed we can just revert this code!


> 
> > Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:135
> >              let reader = new FileReader;
> 
> You could also move this inside the `Promise` as well, as it's not needed
> anywhere outside.

Might as well!

[Joseph Pecoraro]

Created attachment 377554 [details]
[PATCH] For Landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 377554 [details]:

svg/custom/tabindex-order.html bug 201294 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 377554 [details]
[PATCH] For Landing

Clearing flags on attachment: 377554

Committed r249248: <https://trac.webkit.org/changeset/249248>