199234 – [ews-build] Enable WPE and GTK queues on new EWS

RESOLVED FIXED 199234

[ews-build] Enable WPE and GTK queues on new EWS

https://bugs.webkit.org/show_bug.cgi?id=199234

Summary [ews-build] Enable WPE and GTK queues on new EWS

Aakash Jain

Reported 2019-06-26 13:52:10 PDT

Enable WPE and GTK queues on new EWS.

Attachments
Patch (2.50 KB, patch) 2019-06-26 13:55 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Patch (7.47 KB, patch) 2019-07-03 04:43 PDT, Aakash Jain	jbedard: review+	Details Formatted Diff Diff
Patch for landing (9.02 KB, patch) 2019-07-03 11:34 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-06-26 13:55:38 PDT

Created attachment 372949 [details] Patch

Aakash Jain

Comment 2 2019-07-03 04:43:44 PDT

Created attachment 373387 [details] Patch

EWS Watchlist

Comment 3 2019-07-03 04:45:03 PDT Comment hidden (obsolete)

Attachment 373387 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:587: [TestCompileWebKit.test_success_gtk] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:587: [TestCompileWebKit.test_success_gtk] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:602: [TestCompileWebKit.test_success_wpe] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:602: [TestCompileWebKit.test_success_wpe] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 4 2019-07-03 05:17:47 PDT

Sample runs: https://ews-build.webkit-uat.org/#/builders/7/builds/477 https://ews-build.webkit-uat.org/#/builders/7/builds/438

Aakash Jain

Comment 5 2019-07-03 11:34:24 PDT

Created attachment 373403 [details] Patch for landing Updated BuildSlaveSupport/ews-app/ews/views/statusbubble.py to enable wpe and gtk status bubbles.

WebKit Commit Bot

Comment 6 2019-07-03 18:45:43 PDT

Comment on attachment 373403 [details] Patch for landing Clearing flags on attachment: 373403 Committed r247131: <https://trac.webkit.org/changeset/247131>

WebKit Commit Bot

Comment 7 2019-07-03 18:45:44 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-07-03 18:46:15 PDT

<rdar://problem/52623540>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Aakash Jain

Reported

2019-06-26 13:52 PDT

Modified

2019-07-03 18:46 PDT History

CC List

9 users Show

URL

Keywords InRadar

Depends on

Blocks