Bug 196657 - [ews-build] Make PrintConfiguration platform aware
Summary: [ews-build] Make PrintConfiguration platform aware
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-04-05 14:42 PDT by Aakash Jain
Modified: 2019-07-03 05:22 PDT (History)
9 users (show)

See Also:

Patch (2.09 KB, patch)
2019-04-05 14:46 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2019-07-02 04:57 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-05 14:42:29 PDT
PrintConfiguration step currently fails on windows as it runs macOS specific commands (e.g.: xcodebuild). We should add an OS check in there.
Comment 1 Aakash Jain 2019-04-05 14:46:14 PDT
Created attachment 366844 [details]
Comment 2 EWS Watchlist 2019-04-05 14:50:58 PDT
Attachment 366844 [details] did not pass style-queue:

ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:912:  [PrintConfiguration.run] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:913:  [PrintConfiguration.run] Instance of 'PrintConfiguration' has no 'getProperty' member  [pylint/E1101] [5]
Total errors found: 2 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Aakash Jain 2019-07-02 04:57:57 PDT
Created attachment 373314 [details]
Comment 4 WebKit Commit Bot 2019-07-02 07:43:03 PDT
Comment on attachment 373314 [details]

Clearing flags on attachment: 373314

Committed r247049: <https://trac.webkit.org/changeset/247049>
Comment 5 WebKit Commit Bot 2019-07-02 07:43:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-02 07:44:19 PDT