RESOLVED FIXED 196657
[ews-build] Make PrintConfiguration platform aware 
https://bugs.webkit.org/show_bug.cgi?id=196657
Summary [ews-build] Make PrintConfiguration platform aware
Aakash Jain
Reported 2019-04-05 14:42:29 PDT
PrintConfiguration step currently fails on windows as it runs macOS specific commands (e.g.: xcodebuild). We should add an OS check in there.
Attachments
Patch (2.09 KB, patch)
2019-04-05 14:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2019-07-02 04:57 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-05 14:46:14 PDT
Created attachment 366844 [details] Patch
EWS Watchlist
Comment 2 2019-04-05 14:50:58 PDT
Attachment 366844 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:912: [PrintConfiguration.run] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:913: [PrintConfiguration.run] Instance of 'PrintConfiguration' has no 'getProperty' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Aakash Jain
Comment 3 2019-07-02 04:57:57 PDT
Created attachment 373314 [details] Patch
WebKit Commit Bot
Comment 4 2019-07-02 07:43:03 PDT
Comment on attachment 373314 [details] Patch Clearing flags on attachment: 373314 Committed r247049: <https://trac.webkit.org/changeset/247049>
WebKit Commit Bot
Comment 5 2019-07-02 07:43:04 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-02 07:44:19 PDT
<rdar://problem/52522637>
Note You need to log in before you can comment on or make changes to this bug.