Bug 199238 - [ews-build] Update bot configuration for WPE and GTK
Summary: [ews-build] Update bot configuration for WPE and GTK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-26 15:49 PDT by Aakash Jain
Modified: 2019-07-02 23:46 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2019-06-26 15:51 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2019-07-02 07:37 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-26 15:49:00 PDT
Update bot configuration for WPE and GTK (to add new bots to the configuration).
Comment 1 Aakash Jain 2019-06-26 15:51:40 PDT
Created attachment 372959 [details]
Patch
Comment 2 Aakash Jain 2019-06-26 15:52:37 PDT
These bots were recently active on old EWS. Please let me know if any other bots need to be added to GTK, WPE queues.
Comment 3 Aakash Jain 2019-07-02 07:02:59 PDT
ping igalia reviewers.
Comment 4 Adrian Perez 2019-07-02 07:19:54 PDT
Comment on attachment 372959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372959&action=review

Reviewing informally: changes LGTM, with a nit about the bot
identifiers which have the compiler version in them—it seems
better to rename them.

I'll try and ping our reviewers to get this rubber-stamped.

> Tools/BuildSlaveSupport/ews-build/config.json:24
> +      "name": "aperez-gtk-gcc7-ews",

This could be just “aperez-gtk-ews”.

> Tools/BuildSlaveSupport/ews-build/config.json:48
> +      "name": "aperez-wpe-gcc7-ews",

Same, this could be “aperez-wpe-ews”.

> Tools/BuildSlaveSupport/ews-build/config.json:410
> +      "workernames": ["igalia-wpe-ews", "aperez-wpe-gcc5-ews", "aperez-wpe-gcc6-ews", "aperez-wpe-gcc7-ews"]

Here you could remove “aperez-wpe-gcc5-ews” and “aperez-wpe-gcc6-ews”.
I used to change the bot identifier with each bump to the compiler
version to make it clearer which version of GCC it was running.

Probably it's better to replace “aperez-wpe-gcc7-ews” with a
plain “aperez-wpe-ews”, because CMake prints anyway the version
of the compiler during the configuration.
Comment 5 Aakash Jain 2019-07-02 07:37:23 PDT
Created attachment 373320 [details]
Patch
Comment 6 Aakash Jain 2019-07-02 07:38:02 PDT
(In reply to Adrian Perez from comment #4)
> Reviewing informally: changes LGTM, with a nit about the bot identifiers which have the compiler version in them—it seems better to rename them.
Renamed.
Comment 7 Carlos Alberto Lopez Perez 2019-07-02 07:42:36 PDT
Comment on attachment 373320 [details]
Patch

Looks good. Thanks!
Comment 8 ews-feeder 2019-07-02 08:02:07 PDT
Comment on attachment 373320 [details]
Patch

Rejecting attachment 373320 [details] from review queue.

clopez@igalia.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 9 Carlos Alberto Lopez Perez 2019-07-02 08:13:46 PDT
(In reply to ews-feeder from comment #8)
> Comment on attachment 373320 [details]
> Patch
> 
> Rejecting attachment 373320 [details] from review queue.
> 
> clopez@igalia.com does not have reviewer permissions according to
> https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> contributors.json.
> 
> - If you do not have reviewer rights please read
> http://webkit.org/coding/contributing.html for instructions on how to use
> bugzilla flags.
> 
> - If you have reviewer rights please correct the error in
> Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> the file (no review needed).  The commit-queue restarts itself every 2
> hours.  After restart the commit-queue will correctly respect your reviewer
> rights.

mmmm.. it looks somehow i lost my status at https://trac.webkit.org/changeset/24470
Comment 10 Carlos Alberto Lopez Perez 2019-07-02 08:14:24 PDT
(In reply to Carlos Alberto Lopez Perez from comment #9)
> (In reply to ews-feeder from comment #8)
> > Comment on attachment 373320 [details]
> > Patch
> > 
> > Rejecting attachment 373320 [details] from review queue.
> > 
> > clopez@igalia.com does not have reviewer permissions according to
> > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> > contributors.json.
> > 
> > - If you do not have reviewer rights please read
> > http://webkit.org/coding/contributing.html for instructions on how to use
> > bugzilla flags.
> > 
> > - If you have reviewer rights please correct the error in
> > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> > the file (no review needed).  The commit-queue restarts itself every 2
> > hours.  After restart the commit-queue will correctly respect your reviewer
> > rights.
> 
> mmmm.. it looks somehow i lost my status at
> https://trac.webkit.org/changeset/24470

I mean https://trac.webkit.org/changeset/244705
Comment 11 WebKit Commit Bot 2019-07-02 09:00:11 PDT
Comment on attachment 373320 [details]
Patch

Clearing flags on attachment: 373320

Committed r247051: <https://trac.webkit.org/changeset/247051>
Comment 12 WebKit Commit Bot 2019-07-02 09:00:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-07-02 09:03:59 PDT
<rdar://problem/52526177>
Comment 14 Alexey Proskuryakov 2019-07-02 23:46:17 PDT
> mmmm.. it looks somehow i lost my status at

Following up via e-mail.