Bug 199238 – [ews-build] Update bot configuration for WPE and GTK

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Update bot configuration for WPE and GTK (to add new bots to the configuration).

[Aakash Jain]

Created attachment 372959 [details]
Patch

[Aakash Jain]

These bots were recently active on old EWS. Please let me know if any other bots need to be added to GTK, WPE queues.

[Aakash Jain]

ping igalia reviewers.

[Adrian Perez]

Comment on attachment 372959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372959&action=review

Reviewing informally: changes LGTM, with a nit about the bot
identifiers which have the compiler version in them—it seems
better to rename them.

I'll try and ping our reviewers to get this rubber-stamped.

> Tools/BuildSlaveSupport/ews-build/config.json:24
> +      "name": "aperez-gtk-gcc7-ews",

This could be just “aperez-gtk-ews”.

> Tools/BuildSlaveSupport/ews-build/config.json:48
> +      "name": "aperez-wpe-gcc7-ews",

Same, this could be “aperez-wpe-ews”.

> Tools/BuildSlaveSupport/ews-build/config.json:410
> +      "workernames": ["igalia-wpe-ews", "aperez-wpe-gcc5-ews", "aperez-wpe-gcc6-ews", "aperez-wpe-gcc7-ews"]

Here you could remove “aperez-wpe-gcc5-ews” and “aperez-wpe-gcc6-ews”.
I used to change the bot identifier with each bump to the compiler
version to make it clearer which version of GCC it was running.

Probably it's better to replace “aperez-wpe-gcc7-ews” with a
plain “aperez-wpe-ews”, because CMake prints anyway the version
of the compiler during the configuration.

[Aakash Jain]

Created attachment 373320 [details]
Patch

[Aakash Jain]

(In reply to Adrian Perez from comment #4)
> Reviewing informally: changes LGTM, with a nit about the bot identifiers which have the compiler version in them—it seems better to rename them.
Renamed.

[Carlos Alberto Lopez Perez]

Comment on attachment 373320 [details]
Patch

Looks good. Thanks!

[EWS]

Comment on attachment 373320 [details]
Patch

Rejecting attachment 373320 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Carlos Alberto Lopez Perez]

(In reply to ews-feeder from comment #8)
> Comment on attachment 373320 [details]
> Patch
> 
> Rejecting attachment 373320 [details] from review queue.
> 
> [e-mail] does not have reviewer permissions according to
> https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> contributors.json.
> 
> - If you do not have reviewer rights please read
> http://webkit.org/coding/contributing.html for instructions on how to use
> bugzilla flags.
> 
> - If you have reviewer rights please correct the error in
> Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> the file (no review needed).  The commit-queue restarts itself every 2
> hours.  After restart the commit-queue will correctly respect your reviewer
> rights.

mmmm.. it looks somehow i lost my status at https://trac.webkit.org/changeset/24470

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #9)
> (In reply to ews-feeder from comment #8)
> > Comment on attachment 373320 [details]
> > Patch
> > 
> > Rejecting attachment 373320 [details] from review queue.
> > 
> > [e-mail] does not have reviewer permissions according to
> > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/
> > contributors.json.
> > 
> > - If you do not have reviewer rights please read
> > http://webkit.org/coding/contributing.html for instructions on how to use
> > bugzilla flags.
> > 
> > - If you have reviewer rights please correct the error in
> > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to
> > the file (no review needed).  The commit-queue restarts itself every 2
> > hours.  After restart the commit-queue will correctly respect your reviewer
> > rights.
> 
> mmmm.. it looks somehow i lost my status at
> https://trac.webkit.org/changeset/24470

I mean https://trac.webkit.org/changeset/244705

[WebKit Commit Bot]

Comment on attachment 373320 [details]
Patch

Clearing flags on attachment: 373320

Committed r247051: <https://trac.webkit.org/changeset/247051>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52526177>

[Alexey Proskuryakov]

> mmmm.. it looks somehow i lost my status at

Following up via e-mail.