Bug 198610 - Restrict fast clicks everywhere to desktop content mode
Summary: Restrict fast clicks everywhere to desktop content mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
: 196236 (view as bug list)
Depends on: 198636
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-06 07:20 PDT by Antoine Quint
Modified: 2019-06-07 13:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.85 KB, patch)
2019-06-06 07:21 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-06-06 07:20:12 PDT 
Restrict fast clicks everywhere to desktop content mode
Comment 1 Antoine Quint 2019-06-06 07:21:09 PDT 
Created attachment 371494 [details]
Patch
Comment 2 Antoine Quint 2019-06-06 07:21:15 PDT 
<rdar://problem/50114230>
Comment 3 Antoine Quint 2019-06-06 07:22:45 PDT 
I wasn't sure if:

1. this should control the fasterClicks or fastClicksEverywhere preference
2. tracking the desktop mode state on WebPageProxy was the right thing to do
Comment 4 WebKit Commit Bot 2019-06-06 12:32:58 PDT 
Comment on attachment 371494 [details]
Patch

Clearing flags on attachment: 371494

Committed r246165: <https://trac.webkit.org/changeset/246165>
Comment 5 WebKit Commit Bot 2019-06-06 12:32:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2019-06-06 17:28:14 PDT 
Re-opened since this is blocked by bug 198636
Comment 7 Antoine Quint 2019-06-07 13:28:24 PDT 
*** Bug 196236 has been marked as a duplicate of this bug. ***
Comment 8 Antoine Quint 2019-06-07 13:55:53 PDT 
Committed r246213: <https://trac.webkit.org/changeset/246213>