RESOLVED DUPLICATE of bug 198610 196236
REGRESSION (r243241): [iOS Sim] Layout Test fast/visual-viewport/ios/min-scale-greater-than-one.html is failing
https://bugs.webkit.org/show_bug.cgi?id=196236
Summary REGRESSION (r243241): [iOS Sim] Layout Test fast/visual-viewport/ios/min-scal...
Shawn Roberts
Reported 2019-03-25 18:14:36 PDT
The following layout test is flaky on iOS Simulator Debug fast/visual-viewport/ios/min-scale-greater-than-one.html Probable cause: After r243241 test become a constant failure on the dashboard. Verified locally. Ran tests on r243241 and got close to 100% failure, when running tests in revisions prior to its only a flaky failure. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fvisual-viewport%2Fios%2Fmin-scale-greater-than-one.html Diff : --- /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/fast/visual-viewport/ios/min-scale-greater-than-one-actual.txt @@ -2,7 +2,6 @@ Scrolling to bottom PASS window.scrollY is expectedTop PASS Math.round(boundingClientRect.top) is expectedTop -Tap dispatched Target clicked PASS successfullyParsed is true
Attachments
Radar WebKit Bug Importer
Comment 1 2019-03-25 18:15:53 PDT
Shawn Roberts
Comment 2 2019-03-25 18:22:39 PDT
Marked flaky in https://trac.webkit.org/changeset/243477/webkit while waiting for a fix.
Ryan Haddad
Comment 3 2019-05-03 11:46:26 PDT
*** Bug 196300 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 4 2019-06-05 08:38:15 PDT
This reproduces with ToT on a Release build as well: rwt --release --ios-simulator fast/visual-viewport/ios/min-scale-greater-than-one.html --iterations=100 --force --exit-after-n-failures=1
Antoine Quint
Comment 5 2019-06-05 09:11:31 PDT
This is another case of subsequent taps in tests not working. The theory is that a double tap may be recognized, but the weird thing in this test is that the callback isn’t called, yet the click event comes through. This can easily be fixed by running the test with a 500ms timeout, which will prevent a double-tap from being recognized. But I think I’m going to finally dig into this to find a fix to the root cause since it affects testing and forces tests to run at slower rate than it should have.
Antoine Quint
Comment 6 2019-06-07 13:28:24 PDT
This is actually a dupe of https://bugs.webkit.org/show_bug.cgi?id=198610, we need to restrict fast-click-everywhere to iPads only. *** This bug has been marked as a duplicate of bug 198610 ***
Note You need to log in before you can comment on or make changes to this bug.