Bug 198073 - SVGPropertyTraits and SVG enum types clean up
Summary: SVGPropertyTraits and SVG enum types clean up
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on: 192519 197831 198122
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-21 08:35 PDT by Said Abou-Hallawa
Modified: 2019-05-22 09:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch (213.88 KB, patch)
2019-05-21 09:33 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (213.12 KB, patch)
2019-05-21 18:40 PDT, Said Abou-Hallawa
ews: commit-queue-
Details | Formatted Diff | Diff
Patch for review (87.85 KB, patch)
2019-05-21 18:45 PDT, Said Abou-Hallawa
sabouhallawa: review?
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.17 MB, application/zip)
2019-05-22 07:52 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-05-21 08:35:42 PDT
Delete unnecessary and repeated code for parsing SVG enum types and primitive types.
Comment 1 Said Abou-Hallawa 2019-05-21 09:33:46 PDT
Created attachment 370324 [details]
Patch
Comment 2 Build Bot 2019-05-21 09:35:28 PDT
Attachment 370324 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:35:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Said Abou-Hallawa 2019-05-21 18:40:58 PDT
Created attachment 370367 [details]
Patch
Comment 4 Build Bot 2019-05-21 18:43:55 PDT
Attachment 370367 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:35:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Said Abou-Hallawa 2019-05-21 18:45:11 PDT
Created attachment 370368 [details]
Patch for review
Comment 6 Build Bot 2019-05-22 07:52:34 PDT
Comment on attachment 370367 [details]
Patch

Attachment 370367 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12256590

New failing tests:
storage/indexeddb/modern/get-keyrange.html
js/dom/try-catch-crash.html
js/dom/custom-constructors.html
Comment 7 Build Bot 2019-05-22 07:52:40 PDT
Created attachment 370395 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit