Bug 198122 - Remove the non final propertyRegistry() from the SVG base classes
Summary: Remove the non final propertyRegistry() from the SVG base classes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks: 192519 198073
  Show dependency tree / graph
 
Reported: 2019-05-22 09:00 PDT by Said Abou-Hallawa
Modified: 2019-06-08 18:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (294.03 KB, patch)
2019-05-22 09:04 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (309.36 KB, patch)
2019-05-23 08:12 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (308.65 KB, patch)
2019-06-08 14:55 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch for review (97.76 KB, patch)
2019-06-08 18:12 PDT, Said Abou-Hallawa 		sabouhallawa: review?
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-05-22 09:00:19 PDT 
This saves the memory that is taken by the member SVGPropertyRegistry of the base class. propertyRegistry() is only needed for concrete classes.
Comment 1 Said Abou-Hallawa 2019-05-22 09:04:00 PDT 
Created attachment 370400 [details]
Patch
Comment 2 EWS Watchlist 2019-05-22 09:07:25 PDT 
Attachment 370400 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Said Abou-Hallawa 2019-05-23 08:12:58 PDT 
Created attachment 370506 [details]
Patch
Comment 4 Said Abou-Hallawa 2019-06-08 14:55:25 PDT 
Created attachment 371669 [details]
Patch
Comment 5 EWS Watchlist 2019-06-08 14:57:07 PDT 
Attachment 371669 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 155 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Said Abou-Hallawa 2019-06-08 18:12:14 PDT 
Created attachment 371689 [details]
Patch for review