197831 – Unify the parsing of SVGList super classes

NEW 197831

Unify the parsing of SVGList super classes

https://bugs.webkit.org/show_bug.cgi?id=197831

Summary Unify the parsing of SVGList super classes

Said Abou-Hallawa

Reported 2019-05-13 00:04:32 PDT

The purpose is centralize the parsing of the SVGList superclasses. If an error happens while parsing the list an error will be reported in the console window.

Attachments
Patch (82.50 KB, patch) 2019-05-13 00:06 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-highsierra (3.23 MB, application/zip) 2019-05-13 01:18 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.78 MB, application/zip) 2019-05-13 01:33 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews210 for win-future (13.68 MB, application/zip) 2019-05-13 01:58 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (3.04 MB, application/zip) 2019-05-13 02:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (3.14 MB, application/zip) 2019-05-13 02:04 PDT, EWS Watchlist	no flags	Details
Patch (117.15 KB, patch) 2019-05-15 08:34 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.12 MB, application/zip) 2019-05-15 09:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews212 for win-future (13.45 MB, application/zip) 2019-05-15 09:56 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.69 MB, application/zip) 2019-05-15 09:58 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (2.97 MB, application/zip) 2019-05-15 10:28 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.67 MB, application/zip) 2019-05-15 10:38 PDT, EWS Watchlist	no flags	Details
Patch (122.46 KB, patch) 2019-05-15 19:00 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews214 for win-future (13.41 MB, application/zip) 2019-05-15 23:55 PDT, EWS Watchlist	no flags	Details
Patch (126.92 KB, patch) 2019-05-16 07:49 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews211 for win-future (13.47 MB, application/zip) 2019-05-16 11:45 PDT, EWS Watchlist	no flags	Details
Patch (213.50 KB, patch) 2019-05-21 09:30 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2019-05-13 00:06:34 PDT

Created attachment 369700 [details] Patch

EWS Watchlist

Comment 2 2019-05-13 01:18:36 PDT

Comment on attachment 369700 [details] Patch Attachment 369700 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12173901 New failing tests: imported/blink/svg/dom/viewspec-zoomandpanparams.html imported/blink/svg/dom/viewspec-aspectparams.html imported/blink/svg/dom/viewspec-viewtargetparams.html

EWS Watchlist

Comment 3 2019-05-13 01:18:37 PDT

Created attachment 369708 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-05-13 01:33:05 PDT

Comment on attachment 369700 [details] Patch Attachment 369700 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12173999 New failing tests: imported/blink/svg/dom/viewspec-zoomandpanparams.html imported/blink/svg/dom/viewspec-aspectparams.html imported/blink/svg/dom/viewspec-viewtargetparams.html

EWS Watchlist

Comment 5 2019-05-13 01:33:07 PDT

Created attachment 369711 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-05-13 01:58:46 PDT

Comment on attachment 369700 [details] Patch Attachment 369700 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12174338 New failing tests: imported/blink/svg/dom/viewspec-zoomandpanparams.html imported/blink/svg/dom/viewspec-aspectparams.html imported/blink/svg/dom/viewspec-viewtargetparams.html

EWS Watchlist

Comment 7 2019-05-13 01:58:48 PDT

Created attachment 369714 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

EWS Watchlist

Comment 8 2019-05-13 02:03:17 PDT

Comment on attachment 369700 [details] Patch Attachment 369700 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12174115 New failing tests: imported/blink/svg/dom/viewspec-zoomandpanparams.html imported/blink/svg/dom/viewspec-aspectparams.html imported/blink/svg/dom/viewspec-viewtargetparams.html

EWS Watchlist

Comment 9 2019-05-13 02:03:19 PDT

Created attachment 369715 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2019-05-13 02:04:30 PDT

Comment on attachment 369700 [details] Patch Attachment 369700 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12173996 New failing tests: imported/blink/svg/dom/viewspec-zoomandpanparams.html imported/blink/svg/dom/viewspec-aspectparams.html imported/blink/svg/dom/viewspec-viewtargetparams.html

EWS Watchlist

Comment 11 2019-05-13 02:04:31 PDT

Created attachment 369717 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Said Abou-Hallawa

Comment 12 2019-05-15 08:34:48 PDT

Created attachment 369953 [details] Patch

EWS Watchlist

Comment 13 2019-05-15 09:46:34 PDT

Comment on attachment 369953 [details] Patch Attachment 369953 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12198094 New failing tests: html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html

EWS Watchlist

Comment 14 2019-05-15 09:46:36 PDT

Created attachment 369959 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 15 2019-05-15 09:56:31 PDT

Comment on attachment 369953 [details] Patch Attachment 369953 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12198140 New failing tests: svg/custom/preserve-aspect-ratio-syntax.svg html5lib/generated/run-tests11-write.html html5lib/generated/run-tests11-data.html

EWS Watchlist

Comment 16 2019-05-15 09:56:36 PDT

Created attachment 369962 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

EWS Watchlist

Comment 17 2019-05-15 09:58:12 PDT

Comment on attachment 369953 [details] Patch Attachment 369953 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12198107 New failing tests: html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html

EWS Watchlist

Comment 18 2019-05-15 09:58:14 PDT

Created attachment 369963 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 19 2019-05-15 10:28:21 PDT

Comment on attachment 369953 [details] Patch Attachment 369953 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12198150 New failing tests: html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html

EWS Watchlist

Comment 20 2019-05-15 10:28:23 PDT

Created attachment 369966 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 21 2019-05-15 10:38:30 PDT

Comment on attachment 369953 [details] Patch Attachment 369953 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12198151 New failing tests: html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html

EWS Watchlist

Comment 22 2019-05-15 10:38:33 PDT

Created attachment 369968 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4

Said Abou-Hallawa

Comment 23 2019-05-15 19:00:37 PDT

Created attachment 370017 [details] Patch

EWS Watchlist

Comment 24 2019-05-15 23:55:40 PDT

Comment on attachment 370017 [details] Patch Attachment 370017 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12204544 New failing tests: svg/custom/preserve-aspect-ratio-syntax.svg

EWS Watchlist

Comment 25 2019-05-15 23:55:44 PDT

Created attachment 370027 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Said Abou-Hallawa

Comment 26 2019-05-16 07:49:47 PDT

Created attachment 370041 [details] Patch

EWS Watchlist

Comment 27 2019-05-16 11:45:14 PDT

Comment on attachment 370041 [details] Patch Attachment 370041 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12207865 New failing tests: storage/indexeddb/modern/get-keyrange.html storage/indexeddb/modern/gc-closes-database.html

EWS Watchlist

Comment 28 2019-05-16 11:45:21 PDT

Created attachment 370052 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Said Abou-Hallawa

Comment 29 2019-05-21 09:30:29 PDT

Created attachment 370323 [details] Patch

Note You need to log in before you can comment on or make changes to this bug.

Status NEW

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component SVG

Assignee

Said Abou-Hallawa

Reported

2019-05-13 00:04 PDT

Modified

2019-05-21 09:35 PDT History

CC List

3 users Show

URL

Keywords

Depends on

Blocks

192519 198073

Dependencies

tree graph