Bug 197850 - New EWS: api-ios bubble and info does not differentiate between patch compile failure and ToT compile failure
Summary: New EWS: api-ios bubble and info does not differentiate between patch compile...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-13 13:22 PDT by Daniel Bates
Modified: 2019-06-19 21:06 PDT (History)
3 users (show)

See Also:

Attachments
Misleading compile time failure reason (440.56 KB, image/png)
2019-05-13 13:22 PDT, Daniel Bates 		no flags Details
EWS page showing ToT compile failure (465.71 KB, image/png)
2019-05-13 13:22 PDT, Daniel Bates 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-05-13 13:22:35 PDT 
Created attachment 369772 [details]
Misleading compile time failure reason

New EWS api-ios bubble and the HTML title text (shown when you hover over the bubble) does not differentiate between patch compile failure and ToT compile failure. This caused me to have to take the time to investigate the "failure" for my patch attachment #369760 [details] (bug #197848) only to discover that the EWS bot cannot even build ToT. The old EWS differentiated this case and the HTML title text would reflect the fact that ToT could not be built.
Comment 1 Radar WebKit Bug Importer 2019-05-13 13:22:47 PDT 
<rdar://problem/50735783>
Comment 2 Daniel Bates 2019-05-13 13:22:51 PDT 
Created attachment 369773 [details]
EWS page showing ToT compile failure
Comment 3 Daniel Bates 2019-05-13 13:23:15 PDT 
<https://ews-build.webkit.org/#/builders/13/builds/2052>
Comment 4 Aakash Jain 2019-05-13 13:26:21 PDT 
Thanks for reporting the issue and sorry for the inconvenience caused. I haven't yet implemented the comparison with ToT in case of build failure. I will try to implement it soon.
Comment 5 Aakash Jain 2019-06-19 21:05:53 PDT 
This should be fixed with https://trac.webkit.org/changeset/246609/webkit