Bug 199025 - [ews-build] Add step to analyze Compile WebKit failures
Summary: [ews-build] Add step to analyze Compile WebKit failures
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-06-19 12:25 PDT by Aakash Jain
Modified: 2019-06-19 13:50 PDT (History)
6 users (show)

See Also:

Proposed patch (3.32 KB, patch)
2019-06-19 12:35 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-19 12:25:37 PDT
Currently when a patch fails to build, we un-apply the patch, and build without patch. However, we do not analyze the results. We should add a step to analyze these results. Also when ToT fails to build, instead of marking the patch as failed, we should keep trying indefinitely (like old EWS) until ToT is green again.
Comment 1 Aakash Jain 2019-06-19 12:35:54 PDT
Created attachment 372485 [details]
Proposed patch

Sample run: 

Without failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4178
With failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4182
Comment 2 Aakash Jain 2019-06-19 12:40:25 PDT
Example of similar behavior on old EWS: https://webkit-queues.webkit.org/patch/369760/mac-wk2-ews
Comment 3 WebKit Commit Bot 2019-06-19 13:49:13 PDT
Comment on attachment 372485 [details]
Proposed patch

Clearing flags on attachment: 372485

Committed r246609: <https://trac.webkit.org/changeset/246609>
Comment 4 WebKit Commit Bot 2019-06-19 13:49:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-06-19 13:50:20 PDT