WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193697
[ews-app] Rename ews model steps to step
https://bugs.webkit.org/show_bug.cgi?id=193697
Summary
[ews-app] Rename ews model steps to step
Aakash Jain
Reported
Wednesday, January 23, 2019 12:08:32 AM UTC
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'steps' to 'step' in ews-app model.
Attachments
Proposed patch
(2.01 KB, patch)
2019-01-22 17:04 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Proposed patch
(2.48 KB, patch)
2019-01-23 11:18 PST
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
Wednesday, January 23, 2019 1:04:44 AM UTC
Created
attachment 359813
[details]
Proposed patch
Aakash Jain
Comment 2
Wednesday, January 23, 2019 7:18:38 PM UTC
Created
attachment 359909
[details]
Proposed patch
Kocsen Chung
Comment 3
Wednesday, January 23, 2019 7:21:24 PM UTC
Comment on
attachment 359909
[details]
Proposed patch r+; looks good to me.
Aakash Jain
Comment 4
Wednesday, January 23, 2019 9:54:49 PM UTC
Committed
r240359
: <
https://trac.webkit.org/changeset/240359
>
Radar WebKit Bug Importer
Comment 5
Wednesday, January 23, 2019 9:55:33 PM UTC
<
rdar://problem/47492748
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug