Bug 193697 - [ews-app] Rename ews model steps to step
Summary: [ews-app] Rename ews model steps to step
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-01-22 16:08 PST by Aakash Jain
Modified: 2019-01-23 13:55 PST (History)
5 users (show)

See Also:

Proposed patch (2.01 KB, patch)
2019-01-22 17:04 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (2.48 KB, patch)
2019-01-23 11:18 PST, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-22 16:08:32 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'steps' to 'step' in ews-app model.
Comment 1 Aakash Jain 2019-01-22 17:04:44 PST
Created attachment 359813 [details]
Proposed patch
Comment 2 Aakash Jain 2019-01-23 11:18:38 PST
Created attachment 359909 [details]
Proposed patch
Comment 3 Kocsen Chung 2019-01-23 11:21:24 PST
Comment on attachment 359909 [details]
Proposed patch

r+; looks good to me.
Comment 4 Aakash Jain 2019-01-23 13:54:49 PST
Committed r240359: <https://trac.webkit.org/changeset/240359>
Comment 5 Radar WebKit Bug Importer 2019-01-23 13:55:33 PST