Bug 193729 - [ews-app] Rename ews model buildermappings to buildermapping
Summary: [ews-app] Rename ews model buildermappings to buildermapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-23 10:38 PST by Aakash Jain
Modified: 2019-01-23 14:00 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (5.64 KB, patch)
2019-01-23 11:16 PST, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-23 10:38:01 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'buildermappings' to 'buildermapping' in ews-app model.
Comment 1 Aakash Jain 2019-01-23 11:16:54 PST
Created attachment 359907 [details]
Proposed patch
Comment 2 Kocsen Chung 2019-01-23 11:19:27 PST
Comment on attachment 359907 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:28
> +class BuilderMappings(models.Model):

Should this be singular BuilderMapping ?
Comment 3 Kocsen Chung 2019-01-23 11:20:42 PST
R+; looks good to me.
Comment 4 Lucas Forschler 2019-01-23 13:17:50 PST
Comment on attachment 359907 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:1
> +# Copyright (C) 2018 Apple Inc. All rights reserved.

maybe update this to 2019?
Comment 5 Aakash Jain 2019-01-23 13:59:16 PST
Committed r240361: <https://trac.webkit.org/changeset/240361>
Comment 6 Radar WebKit Bug Importer 2019-01-23 14:00:32 PST
<rdar://problem/47492954>