RESOLVED FIXED 193729
[ews-app] Rename ews model buildermappings to buildermapping 
https://bugs.webkit.org/show_bug.cgi?id=193729
Summary [ews-app] Rename ews model buildermappings to buildermapping
Aakash Jain
Reported 2019-01-23 10:38:01 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'buildermappings' to 'buildermapping' in ews-app model.
Attachments
Proposed patch (5.64 KB, patch)
2019-01-23 11:16 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-23 11:16:54 PST
Created attachment 359907 [details] Proposed patch
Kocsen Chung
Comment 2 2019-01-23 11:19:27 PST
Comment on attachment 359907 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:28 > +class BuilderMappings(models.Model): Should this be singular BuilderMapping ?
Kocsen Chung
Comment 3 2019-01-23 11:20:42 PST
R+; looks good to me.
Lucas Forschler
Comment 4 2019-01-23 13:17:50 PST
Comment on attachment 359907 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved. maybe update this to 2019?
Aakash Jain
Comment 5 2019-01-23 13:59:16 PST
Committed r240361: <https://trac.webkit.org/changeset/240361>
Radar WebKit Bug Importer
Comment 6 2019-01-23 14:00:32 PST
<rdar://problem/47492954>
Note You need to log in before you can comment on or make changes to this bug.