WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193695
[ews-app] Rename ews model Builds to Build
https://bugs.webkit.org/show_bug.cgi?id=193695
Summary
[ews-app] Rename ews model Builds to Build
Aakash Jain
Reported
2019-01-22 16:04:46 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'Builds' to 'Build' in ews-app model.
Attachments
Proposed patch
(2.86 KB, patch)
2019-01-22 17:04 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Proposed patch
(3.33 KB, patch)
2019-01-23 11:18 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-01-22 17:04:01 PST
Created
attachment 359812
[details]
Proposed patch
Aakash Jain
Comment 2
2019-01-23 11:18:01 PST
Created
attachment 359908
[details]
Proposed patch
Kocsen Chung
Comment 3
2019-01-23 11:20:30 PST
r+; looks good to me.
WebKit Commit Bot
Comment 4
2019-01-23 13:37:35 PST
Comment on
attachment 359908
[details]
Proposed patch Clearing flags on attachment: 359908 Committed
r240357
: <
https://trac.webkit.org/changeset/240357
>
WebKit Commit Bot
Comment 5
2019-01-23 13:37:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-01-23 13:38:48 PST
<
rdar://problem/47492092
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug