Bug 193695 - [ews-app] Rename ews model Builds to Build
Summary: [ews-app] Rename ews model Builds to Build
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-01-22 16:04 PST by Aakash Jain
Modified: 2019-01-23 13:38 PST (History)
6 users (show)

See Also:

Proposed patch (2.86 KB, patch)
2019-01-22 17:04 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (3.33 KB, patch)
2019-01-23 11:18 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-22 16:04:46 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'Builds' to 'Build' in ews-app model.
Comment 1 Aakash Jain 2019-01-22 17:04:01 PST
Created attachment 359812 [details]
Proposed patch
Comment 2 Aakash Jain 2019-01-23 11:18:01 PST
Created attachment 359908 [details]
Proposed patch
Comment 3 Kocsen Chung 2019-01-23 11:20:30 PST
r+; looks good to me.
Comment 4 WebKit Commit Bot 2019-01-23 13:37:35 PST
Comment on attachment 359908 [details]
Proposed patch

Clearing flags on attachment: 359908

Committed r240357: <https://trac.webkit.org/changeset/240357>
Comment 5 WebKit Commit Bot 2019-01-23 13:37:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-23 13:38:48 PST