RESOLVED FIXED193010
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class 
https://bugs.webkit.org/show_bug.cgi?id=193010
Summary Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum...
Simon Fraser (smfr)
Reported 2018-12-22 11:37:00 PST
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
Attachments
Patch (16.84 KB, patch)
2018-12-22 11:38 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-12-22 11:38:18 PST
Created attachment 358024 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-12-22 11:38:45 PST
Might conflict with the patch in bug 193009.
Simon Fraser (smfr)
Comment 3 2019-01-02 13:22:33 PST
https://trac.webkit.org/r239576
Radar WebKit Bug Importer
Comment 4 2019-01-02 13:23:36 PST
<rdar://problem/47009446>
Frédéric Wang (:fredw)
Comment 5 2019-01-04 06:11:47 PST
Comment on attachment 358024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358024&action=review > Source/WebCore/rendering/RenderLayerCompositor.h:474 > + // FIXME: make the coordinated/async terminology consistent. Can you please elaborate about this FIXME? Do you think we use "Coordinated" or "Async" scrolling everywhere?
Simon Fraser (smfr)
Comment 6 2019-01-04 10:10:02 PST
(In reply to Frédéric Wang (:fredw) from comment #5) > Comment on attachment 358024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > + // FIXME: make the coordinated/async terminology consistent. > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > or "Async" scrolling everywhere? I think we should pick one and stick with it, yes.
Frédéric Wang (:fredw)
Comment 7 2019-01-16 02:22:59 PST
(In reply to Simon Fraser (smfr) from comment #6) > (In reply to Frédéric Wang (:fredw) from comment #5) > > Comment on attachment 358024 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > > + // FIXME: make the coordinated/async terminology consistent. > > > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > > or "Async" scrolling everywhere? > > I think we should pick one and stick with it, yes. For the record, I've opened https://bugs.webkit.org/show_bug.cgi?id=193394 but I'm not exactly how much we want to do.
Note You need to log in before you can comment on or make changes to this bug.