Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
Created attachment 358024 [details] Patch
Might conflict with the patch in bug 193009.
https://trac.webkit.org/r239576
<rdar://problem/47009446>
Comment on attachment 358024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358024&action=review > Source/WebCore/rendering/RenderLayerCompositor.h:474 > + // FIXME: make the coordinated/async terminology consistent. Can you please elaborate about this FIXME? Do you think we use "Coordinated" or "Async" scrolling everywhere?
(In reply to Frédéric Wang (:fredw) from comment #5) > Comment on attachment 358024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > + // FIXME: make the coordinated/async terminology consistent. > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > or "Async" scrolling everywhere? I think we should pick one and stick with it, yes.
(In reply to Simon Fraser (smfr) from comment #6) > (In reply to Frédéric Wang (:fredw) from comment #5) > > Comment on attachment 358024 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > > + // FIXME: make the coordinated/async terminology consistent. > > > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > > or "Async" scrolling everywhere? > > I think we should pick one and stick with it, yes. For the record, I've opened https://bugs.webkit.org/show_bug.cgi?id=193394 but I'm not exactly how much we want to do.