Bug 193009 - Change ScrollingNodeType to an enum class
Summary: Change ScrollingNodeType to an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-22 10:57 PST by Simon Fraser (smfr)
Modified: 2019-01-02 13:24 PST (History)
6 users (show)

See Also:


Attachments
Patch (34.13 KB, patch)
2018-12-22 10:57 PST, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff
Patch (37.13 KB, patch)
2018-12-24 09:38 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (37.10 KB, patch)
2018-12-24 09:43 PST, Simon Fraser (smfr)
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.77 MB, application/zip)
2018-12-24 11:48 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-12-22 10:57:09 PST
Change ScrollingNodeType to an enum class
Comment 1 Simon Fraser (smfr) 2018-12-22 10:57:56 PST
Created attachment 358023 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-12-24 09:38:44 PST
Created attachment 358042 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-12-24 09:43:39 PST
Created attachment 358043 [details]
Patch
Comment 4 WebKit Commit Bot 2018-12-24 11:20:26 PST
Comment on attachment 358043 [details]
Patch

Clearing flags on attachment: 358043

Committed r239548: <https://trac.webkit.org/changeset/239548>
Comment 5 EWS Watchlist 2018-12-24 11:48:17 PST
Comment on attachment 358043 [details]
Patch

Attachment 358043 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10536279

New failing tests:
webanimations/leak-document-with-web-animation.html
Comment 6 EWS Watchlist 2018-12-24 11:48:29 PST
Created attachment 358044 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Radar WebKit Bug Importer 2019-01-02 13:24:29 PST
<rdar://problem/47009480>