NEW193394
Make the scrolling code use "Async" instead of "Coordinated" 
https://bugs.webkit.org/show_bug.cgi?id=193394
Summary Make the scrolling code use "Async" instead of "Coordinated"
Frédéric Wang (:fredw)
Reported 2019-01-14 03:02:25 PST
Coordinated is used in various places but the async is used in preference options, build option and the "base" class AsyncScrollingCoordinator.
Attachments
Patch (32.89 KB, patch)
2019-01-14 03:04 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (34.39 KB, patch)
2019-01-14 07:42 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2019-01-14 03:04:10 PST
Created attachment 359024 [details] Patch
EWS Watchlist
Comment 2 2019-01-14 03:08:51 PST
Attachment 359024 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Frédéric Wang (:fredw)
Comment 3 2019-01-14 07:42:30 PST
Created attachment 359036 [details] Patch This is WIP, but I'm not sure what difference we make between 'coordinated' and 'async'. It seems most of the 'coordinated' operations actually assume a scrolling tree (hence are 'async' scrolling) except maybe the m_legacyScrollingLayerCoordinator->registerAllViewportConstrainedLayers calls. @smfr: Do you think we could actually merge AsyncScrollingCoordinator into ScrollingCoordinator?
Frédéric Wang (:fredw)
Comment 4 2019-02-21 08:15:22 PST
Comment on attachment 359036 [details] Patch Patch is likely bitrotten, but just asking for review in order to get some feedback and so that we don't forget about it.
Frédéric Wang (:fredw)
Comment 5 2019-02-27 07:40:02 PST
Comment on attachment 359036 [details] Patch mmh, it seems there are too many rebase conflicts here... It would probably be easier to start the patch again from scratch.
Frédéric Wang (:fredw)
Comment 6 2025-07-07 05:23:57 PDT
Unassigning myself since I'm no longer working on this.
Note You need to log in before you can comment on or make changes to this bug.