Bug 193394 - Make the scrolling code use "Async" instead of "Coordinated"
Summary: Make the scrolling code use "Async" instead of "Coordinated"
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
Depends on:
Reported: 2019-01-14 03:02 PST by Frédéric Wang (:fredw)
Modified: 2019-02-27 07:40 PST (History)
1 user (show)

See Also:

Patch (32.89 KB, patch)
2019-01-14 03:04 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (34.39 KB, patch)
2019-01-14 07:42 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2019-01-14 03:02:25 PST
Coordinated is used in various places but the async is used in preference options, build option and the "base" class AsyncScrollingCoordinator.
Comment 1 Frédéric Wang (:fredw) 2019-01-14 03:04:10 PST
Created attachment 359024 [details]
Comment 2 EWS Watchlist 2019-01-14 03:08:51 PST
Attachment 359024 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Frédéric Wang (:fredw) 2019-01-14 07:42:30 PST
Created attachment 359036 [details]

This is WIP, but I'm not sure what difference we make between 'coordinated' and 'async'. It seems most of the 'coordinated' operations actually assume a scrolling tree (hence are 'async' scrolling) except maybe the m_legacyScrollingLayerCoordinator->registerAllViewportConstrainedLayers calls.

@smfr: Do you think we could actually merge AsyncScrollingCoordinator into ScrollingCoordinator?
Comment 4 Frédéric Wang (:fredw) 2019-02-21 08:15:22 PST
Comment on attachment 359036 [details]

Patch is likely bitrotten, but just asking for review in order to get some feedback and so that we don't forget about it.
Comment 5 Frédéric Wang (:fredw) 2019-02-27 07:40:02 PST
Comment on attachment 359036 [details]

mmh, it seems there are too many rebase conflicts here... It would probably be easier to start the patch again from scratch.