Bug 192952 - Add API test coverage for customUserAgent client setting and service workers
Summary: Add API test coverage for customUserAgent client setting and service workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 192951
  Show dependency treegraph
 
Reported: 2018-12-20 13:35 PST by Chris Dumez
Modified: 2018-12-20 17:26 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.73 KB, patch)
2018-12-20 13:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (5.73 KB, patch)
2018-12-20 16:10 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-20 13:35:57 PST
Add API test coverage for customUserAgent client setting and service workers.
Comment 1 Chris Dumez 2018-12-20 13:39:26 PST
Created attachment 357861 [details]
Patch
Comment 2 Build Bot 2018-12-20 13:43:47 PST
Attachment 357861 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2018-12-20 16:10:07 PST
Created attachment 357892 [details]
Patch
Comment 4 Alex Christensen 2018-12-20 16:11:38 PST
Comment on attachment 357892 [details]
Patch

Great FIXME
Comment 5 Build Bot 2018-12-20 16:12:59 PST
Attachment 357892 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2018-12-20 17:24:41 PST
The commit-queue encountered the following flaky tests while processing attachment 357892 [details]:

storage/indexeddb/objectstore-basics-workers.html bug 192965 (authors: beidson@apple.com, commit-queue@webkit.org, and mark.lam@apple.com)
http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-12-20 17:25:24 PST
Comment on attachment 357892 [details]
Patch

Clearing flags on attachment: 357892

Committed r239480: <https://trac.webkit.org/changeset/239480>
Comment 8 WebKit Commit Bot 2018-12-20 17:25:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-12-20 17:26:29 PST
<rdar://problem/46888770>