Bug 192500 - [LFC] Rename formattingContext() to createFormattingContext()
Summary: [LFC] Rename formattingContext() to createFormattingContext()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-07 10:14 PST by Antti Koivisto
Modified: 2018-12-07 11:26 PST (History)
5 users (show)

See Also:

Attachments
patch (6.42 KB, patch)
2018-12-07 10:16 PST, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (9.84 KB, patch)
2018-12-07 10:26 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-12-07 10:14:10 PST 
It is not an accessor.
Comment 1 Antti Koivisto 2018-12-07 10:16:21 PST 
Created attachment 356818 [details]
patch
Comment 2 zalan 2018-12-07 10:17:20 PST 
Comment on attachment 356818 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356818&action=review

> Source/WebCore/layout/FormattingState.h:49
> +    virtual std::unique_ptr<FormattingContext> createFormattingContext(const Box& formattingContextRoot) = 0;

Very nice. I wonder who reviewed this originally.
Comment 3 Antti Koivisto 2018-12-07 10:22:29 PST 
> Very nice. I wonder who reviewed this originally.

Probably someone using a watch for reviews.
Comment 4 Antti Koivisto 2018-12-07 10:26:38 PST 
Created attachment 356819 [details]
patch
Comment 5 WebKit Commit Bot 2018-12-07 11:19:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 356819 [details]:

imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CBC.https.any.worker.html bug 192505
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2018-12-07 11:19:10 PST 
The commit-queue encountered the following flaky tests while processing attachment 356819 [details]:

imported/w3c/web-platform-tests/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-3.htm bug 192506 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-12-07 11:25:53 PST 
Comment on attachment 356819 [details]
patch

Clearing flags on attachment: 356819

Committed r238961: <https://trac.webkit.org/changeset/238961>
Comment 8 WebKit Commit Bot 2018-12-07 11:25:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-12-07 11:26:44 PST 
<rdar://problem/46559821>