Bug 192193 - Add initial support for 'Cross-Origin-Opener-Policy' HTTP header
Summary: Add initial support for 'Cross-Origin-Opener-Policy' HTTP header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/whatwg/html/issues...
Keywords: InRadar
Depends on: 228080 228254 228287
Blocks: 228755
  Show dependency treegraph
 
Reported: 2018-11-29 15:19 PST by Chris Dumez
Modified: 2021-09-07 10:36 PDT (History)
27 users (show)

See Also:


Attachments
Patch (53.66 KB, patch)
2018-11-29 16:57 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.48 MB, application/zip)
2018-11-29 18:40 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (16.87 MB, application/zip)
2018-11-29 20:08 PST, EWS Watchlist
no flags Details
Patch (54.38 KB, patch)
2018-11-30 09:07 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (57.63 KB, patch)
2018-11-30 09:19 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (71.02 KB, patch)
2018-11-30 10:41 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (73.28 KB, patch)
2018-11-30 11:51 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (136.73 KB, patch)
2021-07-20 17:48 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (151.68 KB, patch)
2021-07-21 17:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (164.48 KB, patch)
2021-07-22 13:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (176.25 KB, patch)
2021-07-22 17:35 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (178.27 KB, patch)
2021-07-23 14:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (179.24 KB, patch)
2021-07-23 15:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (178.84 KB, patch)
2021-07-23 16:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (178.82 KB, patch)
2021-07-27 08:34 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (195.34 KB, patch)
2021-07-27 14:29 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (199.83 KB, patch)
2021-07-28 10:28 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (203.52 KB, patch)
2021-07-28 10:41 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (223.30 KB, patch)
2021-07-28 14:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (225.81 KB, patch)
2021-07-30 13:15 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-11-29 15:19:55 PST
Add initial support for 'Cross-Origin-Opener-Policy' HTTP header:
- https://github.com/whatwg/html/issues/3740
Comment 1 Chris Dumez 2018-11-29 15:20:08 PST
<rdar://problem/42013525>
Comment 2 Chris Dumez 2018-11-29 16:57:44 PST
Created attachment 356095 [details]
Patch
Comment 3 EWS Watchlist 2018-11-29 16:59:50 PST
Attachment 356095 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:354:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:362:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:364:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:366:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3123:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3125:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3129:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 9 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EWS Watchlist 2018-11-29 18:39:59 PST
Comment on attachment 356095 [details]
Patch

Attachment 356095 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10206760

New failing tests:
http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html
http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html
http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html
http/tests/navigation/window-open-cross-origin-then-navigated-back-same-origin.html
Comment 5 EWS Watchlist 2018-11-29 18:40:01 PST
Created attachment 356103 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-11-29 20:08:12 PST
Comment on attachment 356095 [details]
Patch

Attachment 356095 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10207300

New failing tests:
http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html
http/tests/navigation/window-open-cross-origin-then-navigated-back-same-origin.html
Comment 7 EWS Watchlist 2018-11-29 20:08:14 PST
Created attachment 356115 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 Ryosuke Niwa 2018-11-29 20:44:20 PST
Comment on attachment 356095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356095&action=review

> Source/WebCore/loader/FrameLoader.cpp:3521
> +void FrameLoader::isolateIfNecessaryDueCrossOriginOpenerPolicy(const String& content, const URL& destinationURL)

DueToCrossOriginOpenerPolicy??

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3224
> +}

Can we also add a test to make sure targeted navigation wouldn't use the same namespace once we created a new browsing context group?
Comment 9 Chris Dumez 2018-11-30 08:03:17 PST
(In reply to Ryosuke Niwa from comment #8)
> Comment on attachment 356095 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356095&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:3521
> > +void FrameLoader::isolateIfNecessaryDueCrossOriginOpenerPolicy(const String& content, const URL& destinationURL)
> 
> DueToCrossOriginOpenerPolicy??
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3224
> > +}
> 
> Can we also add a test to make sure targeted navigation wouldn't use the
> same namespace once we created a new browsing context group?

If I understand your request correctly, this is already covered by my layout test.
Comment 10 Chris Dumez 2018-11-30 09:07:25 PST
Created attachment 356182 [details]
Patch
Comment 11 EWS Watchlist 2018-11-30 09:10:17 PST
Attachment 356182 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:354:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:362:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:364:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:366:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3123:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3125:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3129:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 9 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Chris Dumez 2018-11-30 09:19:30 PST
Created attachment 356185 [details]
Patch
Comment 13 Chris Dumez 2018-11-30 09:20:33 PST
(In reply to Chris Dumez from comment #9)
> (In reply to Ryosuke Niwa from comment #8)
> > Comment on attachment 356095 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=356095&action=review
> > 
> > > Source/WebCore/loader/FrameLoader.cpp:3521
> > > +void FrameLoader::isolateIfNecessaryDueCrossOriginOpenerPolicy(const String& content, const URL& destinationURL)
> > 
> > DueToCrossOriginOpenerPolicy??
> > 
> > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3224
> > > +}
> > 
> > Can we also add a test to make sure targeted navigation wouldn't use the
> > same namespace once we created a new browsing context group?
> 
> If I understand your request correctly, this is already covered by my layout
> test.

The existing layout test is doing name targeting via window.open(). My latest iteration also adds an API test that covers name targeting via <a target=x>.
Comment 14 EWS Watchlist 2018-11-30 09:21:40 PST
Attachment 356185 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:354:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:362:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:364:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:367:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:371:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:373:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:375:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3132:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3134:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3138:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 12 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Chris Dumez 2018-11-30 10:41:22 PST
Created attachment 356196 [details]
Patch
Comment 16 EWS Watchlist 2018-11-30 10:43:30 PST
Attachment 356196 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:354:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:362:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:364:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:367:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:371:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:373:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:375:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3133:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3135:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3139:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 12 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Chris Dumez 2018-11-30 11:51:55 PST
Created attachment 356213 [details]
Patch
Comment 18 EWS Watchlist 2018-11-30 11:57:10 PST
Attachment 356213 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:354:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:362:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:364:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:367:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:371:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:373:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:375:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3138:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3140:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3144:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 12 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 Chris Dumez 2018-11-30 13:57:56 PST
Too complex.
Comment 20 Chris Dumez 2021-07-19 10:28:17 PDT
Reopening as I am going to take another shot at this.
Comment 21 Chris Dumez 2021-07-20 17:48:04 PDT
Created attachment 433910 [details]
WIP Patch
Comment 22 Chris Dumez 2021-07-21 17:05:31 PDT
Created attachment 433976 [details]
WIP Patch
Comment 23 Chris Dumez 2021-07-22 13:17:50 PDT
Created attachment 434029 [details]
WIP Patch
Comment 24 Chris Dumez 2021-07-22 17:35:36 PDT
Created attachment 434047 [details]
WIP Patch
Comment 25 Chris Dumez 2021-07-23 14:58:54 PDT
Created attachment 434127 [details]
WIP Patch
Comment 26 EWS Watchlist 2021-07-23 14:59:51 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 27 Chris Dumez 2021-07-23 15:59:50 PDT
Created attachment 434134 [details]
WIP Patch
Comment 28 Chris Dumez 2021-07-23 16:07:11 PDT
Created attachment 434136 [details]
WIP Patch
Comment 29 Chris Dumez 2021-07-27 08:34:23 PDT
Created attachment 434288 [details]
WIP Patch
Comment 30 Chris Dumez 2021-07-27 14:29:58 PDT
Created attachment 434317 [details]
WIP Patch
Comment 31 Chris Dumez 2021-07-27 14:31:11 PDT
I filed the following issue against the spec:
- https://github.com/whatwg/html/issues/6903

I had to make a change to checkIfCOOPValuesRequireBrowsingContextGroupSwitch() that is not part of the spec in order to make this test pass.

Either the spec is incomplete or I have an implementation bug elsewhere.
Comment 32 Chris Dumez 2021-07-28 10:28:12 PDT
Created attachment 434433 [details]
WIP Patch

There are still some failures in imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html that I need to figure out.

There are also some blob-related failures but I may address those separately as the fix doesn't seem trivial.
Comment 33 Chris Dumez 2021-07-28 10:41:42 PDT
Created attachment 434436 [details]
WIP Patch
Comment 34 Chris Dumez 2021-07-28 14:48:59 PDT
Created attachment 434468 [details]
Patch
Comment 35 Geoffrey Garen 2021-07-30 13:06:32 PDT
Comment on attachment 434468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434468&action=review

r=me

> Source/WebCore/ChangeLog:25
> +        merely so isolation of the new browsing context at JS level for now. At some point,

so -> do
Comment 36 Chris Dumez 2021-07-30 13:15:40 PDT
Created attachment 434660 [details]
Patch
Comment 37 EWS 2021-07-30 17:07:46 PDT
Committed r280504 (240136@main): <https://commits.webkit.org/240136@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434660 [details].