Bug 192092 - Import fetch/api/cors tests
Summary: Import fetch/api/cors tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 11:50 PST by Rob Buis
Modified: 2018-11-29 02:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (65.53 KB, patch)
2018-11-28 12:02 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (65.57 KB, patch)
2018-11-29 01:32 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-11-28 11:50:20 PST
fetch/api/cors has some new rewritten tests that now pass.
Comment 1 Rob Buis 2018-11-28 12:02:09 PST
Created attachment 355901 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-11-28 14:16:46 PST
Comment on attachment 355901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355901&action=review

> LayoutTests/imported/w3c/resources/import-expectations.json:152
> +    "web-platform-tests/fetch/api/cors/": "import", 

This is probably a but in the import script, but most entries don't use a trailing backslash.
Comment 3 Rob Buis 2018-11-29 01:30:03 PST
(In reply to Frédéric Wang (:fredw) from comment #2)
> Comment on attachment 355901 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355901&action=review
> 
> > LayoutTests/imported/w3c/resources/import-expectations.json:152
> > +    "web-platform-tests/fetch/api/cors/": "import", 
> 
> This is probably a but in the import script, but most entries don't use a
> trailing backslash.

No bug, I accidentally removed it and tried to add it again by hand :) Will fix.
Comment 4 Rob Buis 2018-11-29 01:32:35 PST
Created attachment 355987 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2018-11-29 01:44:32 PST
(In reply to Rob Buis from comment #3)
> (In reply to Frédéric Wang (:fredw) from comment #2)
> > Comment on attachment 355901 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=355901&action=review
> > 
> > > LayoutTests/imported/w3c/resources/import-expectations.json:152
> > > +    "web-platform-tests/fetch/api/cors/": "import", 
> > 
> > This is probably a but in the import script, but most entries don't use a
> > trailing backslash.
> 
> No bug, I accidentally removed it and tried to add it again by hand :) Will
> fix.

I think I remember noticing some time ago that the script just uses the path you pass as a command line argument, without removing trailing backslash.
Comment 6 WebKit Commit Bot 2018-11-29 02:25:17 PST
The commit-queue encountered the following flaky tests while processing attachment 355987 [details]:

http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
webgl/1.0.2/conformance/more/functions/bindBufferBadArgs.html bug 192065 (author: roger_fong@apple.com)
workers/bomb.html bug 171985 (author: fpizlo@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-11-29 02:25:23 PST
The commit-queue encountered the following flaky tests while processing attachment 355987 [details]:

imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.https.any.html bug 192142
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2018-11-29 02:30:37 PST
Comment on attachment 355987 [details]
Patch

Clearing flags on attachment: 355987

Committed r238664: <https://trac.webkit.org/changeset/238664>
Comment 9 WebKit Commit Bot 2018-11-29 02:30:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-29 02:31:30 PST
<rdar://problem/46337506>