Bug 191259 - [GStreamer] video loop sometimes fails
Summary: [GStreamer] video loop sometimes fails
Status: RESOLVED DUPLICATE of bug 211182
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-05 06:06 PST by Philippe Normand
Modified: 2020-05-05 02:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2018-11-05 06:15 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-11-05 06:06:56 PST 
I think this happens since bug 188645 was fixed. At EOS for a looping video the reported position and duration differ, so the media element doesn't seek back to the beginning...
Comment 1 Philippe Normand 2018-11-05 06:15:49 PST 
Created attachment 353855 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-11-05 23:27:52 PST 
Comment on attachment 353855 [details]
Patch

Patch is ok, but we should have a regression test for it.
Comment 3 Philippe Normand 2018-11-06 00:55:36 PST 
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 353855 [details]
> Patch
> 
> Patch is ok, but we should have a regression test for it.

Of course it should... But due to the inconsistent (flaky) nature of the issue, it's going to be hard to get one.
Comment 4 Philippe Normand 2018-11-07 02:10:29 PST 
There's already a test BTW, marked flaky for a long time already, media/video-loop.html
Comment 5 Xabier Rodríguez Calvar 2018-11-07 03:51:13 PST 
(In reply to Philippe Normand from comment #4)
> There's already a test BTW, marked flaky for a long time already,
> media/video-loop.html

Does it pass now reliably?
Comment 6 Philippe Normand 2018-11-07 07:01:54 PST 
Even before the patch it passes reliably here.
Comment 7 Xabier Rodríguez Calvar 2018-11-08 23:52:52 PST 
(In reply to Philippe Normand from comment #6)
> Even before the patch it passes reliably here.

This is even weirder. This is an important feature that is broken, we should really find a way to test this and avoid regressions. Might be related to the video we are using?
Comment 8 Philippe Normand 2020-05-05 02:11:21 PDT 

*** This bug has been marked as a duplicate of bug 211182 ***