Bug 211182 - [GStreamer] Video loops when ran in rr record --chaos
Summary: [GStreamer] Video loops when ran in rr record --chaos
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
: 191259 (view as bug list)
Depends on:
Reported: 2020-04-29 07:24 PDT by Alicia Boya García
Modified: 2020-05-05 07:36 PDT (History)
13 users (show)

See Also:

Patch (4.39 KB, patch)
2020-04-29 07:28 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-04-29 07:24:47 PDT
While trying to investigate a different bug, I ran the browser with
`rr record --chaos`, which makes it run very slowly and shuffles
thread scheduling to try to make existing race conditions more likely
to show up, also inevitably making the software run very slow.

Doing so I found something strange: the video kept looping even though
it didn't have the `loop` attribute set.

After some debugging I found that MediaPlayer decides if the video has
ended in part by checking `currentMediaTime()` is greater or equal to
the video duration, which was not guaranteed to be the case in

As a consequence of this patch, one new LayoutTest has passed.
Comment 1 Alicia Boya García 2020-04-29 07:28:19 PDT
Created attachment 397960 [details]
Comment 2 Philippe Normand 2020-04-29 07:38:55 PDT
Looks similar to bug 191259
Comment 3 Philippe Normand 2020-05-05 02:11:21 PDT
*** Bug 191259 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2020-05-05 07:36:54 PDT
Committed r261165: <https://trac.webkit.org/changeset/261165>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397960 [details].