WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
211182
[GStreamer] Video loops when ran in rr record --chaos
https://bugs.webkit.org/show_bug.cgi?id=211182
Summary
[GStreamer] Video loops when ran in rr record --chaos
Alicia Boya García
Reported
2020-04-29 07:24:47 PDT
While trying to investigate a different bug, I ran the browser with `rr record --chaos`, which makes it run very slowly and shuffles thread scheduling to try to make existing race conditions more likely to show up, also inevitably making the software run very slow. Doing so I found something strange: the video kept looping even though it didn't have the `loop` attribute set. After some debugging I found that MediaPlayer decides if the video has ended in part by checking `currentMediaTime()` is greater or equal to the video duration, which was not guaranteed to be the case in MediaPlayerPrivateGStreamer. As a consequence of this patch, one new LayoutTest has passed.
Attachments
Patch
(4.39 KB, patch)
2020-04-29 07:28 PDT
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2020-04-29 07:28:19 PDT
Created
attachment 397960
[details]
Patch
Philippe Normand
Comment 2
2020-04-29 07:38:55 PDT
Looks similar to
bug 191259
Philippe Normand
Comment 3
2020-05-05 02:11:21 PDT
***
Bug 191259
has been marked as a duplicate of this bug. ***
EWS
Comment 4
2020-05-05 07:36:54 PDT
Committed
r261165
: <
https://trac.webkit.org/changeset/261165
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 397960
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug