.
Created attachment 347261 [details] Patch
Comment on attachment 347261 [details] Patch Attachment 347261 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8887216 New failing tests: http/tests/security/local-video-source-from-remote.html
Created attachment 347341 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 347261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347261&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:351 > + double now = WTF::WallTime::now().secondsSinceEpoch().milliseconds(); > + if (m_lastQuery > -1 && ((now - m_lastQuery) < 300) && m_cachedPosition.isValid()) > + return m_cachedPosition; > + > + m_lastQuery = now; My preference here, to save one variable and one call, would be: (if m_cachedPosition.isValid()) { double now = ... if (m_last...
I don't understand what you mean :)
(In reply to Philippe Normand from comment #5) > I don't understand what you mean :) I meant this: if (m_cachedPosition.isValid()) { double now = WTF::WallTime::now().secondsSinceEpoch().milliseconds(); if (m_lastQuery > -1 && ((now - m_lastQuery) < 300)) return m_cachedPosition; m_lastQuery = now; } but I realize it is stupid as because m_lastQuery = now needs to be done outsize the loop to update it also in case the cached position is invalid and for that you also need the "now" variable. Summing up, forget what I said here and land if you want.
Committed r234983: <https://trac.webkit.org/changeset/234983>
<rdar://problem/43422708>