Bug 190710 – [GTK][WPE] Enable CSS Painting API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

fast/css-custom-paint/basic.html [ Failure ]

with this diff:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css-custom-paint/basic-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css-custom-paint/basic-actual.txt
@@ -1,9 +1,9 @@
 
-PASS test that registerPaint runs 
-PASS test that registerPaint runs without inputProperties 
-PASS test that registerPaint runs with inputArguments 
-PASS test that registerPaint runs with contextOptions 
-PASS test that registerPaint runs with predefined class 
-PASS test that registerPaint accepts only a string and a class constructor 
-PASS test that test div has paint() value 
+FAIL test that registerPaint runs undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL test that registerPaint runs without inputProperties undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL test that registerPaint runs with inputArguments undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL test that registerPaint runs with contextOptions undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL test that registerPaint runs with predefined class undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL test that registerPaint accepts only a string and a class constructor assert_throws: function "() => CSS.paintWorkletGlobalScope.registerPaint('test6', 'test')" threw object "TypeError: undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')" ("TypeError") expected object "[object Object]" ("InvalidModificationError")
+FAIL test that test div has paint() value assert_equals: expected "paint(my-paint)" but got "none"
 

and fast/css-custom-paint/registerPaintBindings.html [ Failure ]

with this diff

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css-custom-paint/registerPaintBindings-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css-custom-paint/registerPaintBindings-actual.txt
@@ -1,13 +1,13 @@
 
-PASS registerPaint must be a method 
-PASS must get "prototype" property of the constructor 
-PASS must rethrow an exception thrown while getting "inputProperties" property of the constructor 
-PASS must rethrow an exception thrown while getting "prototype" property of the constructor 
+FAIL registerPaint must be a method undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.__proto__')
+FAIL must get "prototype" property of the constructor undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL must rethrow an exception thrown while getting "inputProperties" property of the constructor assert_throws: function "function () { CSS.paintWorkletGlobalScope.registerPaint('test-rethrow-inputProperties0', proxy); }" threw object "TypeError: undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')" ("TypeError") expected object "[object Object]" ("expectedError")
+FAIL must rethrow an exception thrown while getting "prototype" property of the constructor assert_throws: function "function () { CSS.paintWorkletGlobalScope.registerPaint('test-rethrow-proto', proxy); }" threw object "TypeError: undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')" ("TypeError") expected object "[object Object]" ("expectedError")
 PASS must throw when "prototype" property of the constructor is not an object 
-PASS must get paint callback of the constructor prototype 
-PASS must rethrow an exception thrown while getting paint callback on the constructor prototype 
-PASS must rethrow an exception thrown while converting paint callback value to Function callback type 
-PASS must rethrow an exception thrown while converting the value of inputArguments to sequence<DOMString> 
-PASS must rethrow an exception thrown while iterating over inputArguments to sequence<DOMString> 
+FAIL must get paint callback of the constructor prototype undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')
+FAIL must rethrow an exception thrown while getting paint callback on the constructor prototype assert_throws: function "function () { CSS.paintWorkletGlobalScope.registerPaint('callbacks-throw', constructor); }" threw object "TypeError: undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')" ("TypeError") expected object "[object Object]" ("expectedError")
+FAIL must rethrow an exception thrown while converting paint callback value to Function callback type assert_array_equals: lengths differ, expected 1 got 0
+FAIL must rethrow an exception thrown while converting the value of inputArguments to sequence<DOMString> assert_array_equals: lengths differ, expected 2 got 0
+FAIL must rethrow an exception thrown while iterating over inputArguments to sequence<DOMString> assert_throws: function "function () { CSS.paintWorkletGlobalScope.registerPaint('sequence-throw2', constructor); }" threw object "TypeError: undefined is not an object (evaluating 'CSS.paintWorkletGlobalScope.registerPaint')" ("TypeError") expected object "[object Object]" ("SomeError")
 PASS must rethrow an exception thrown while retrieving Symbol.iterator on inputArguments

[Claudio Saavedra]

*** Bug 192435 has been marked as a duplicate of this bug. ***

[Claudio Saavedra]

I'm skipping the whole directory instead of marking individual failures since the feature is disabled (same for WPE). Let's revisit the tests once the feature is enabled in the ports (or by default).

[Carlos Alberto Lopez Perez]

Here are some resources/demos for CSS Painting API: 

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Painting_API
https://bobrov.dev/css-paint-demos/

Most of the demos work on GTK/WPE once the feature is enabled and the layout test pass.

So I think its a good idea to enable this (as an experimental feature for now).

[Carlos Alberto Lopez Perez]

Created attachment 383301 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 383301 [details]
Patch

Clearing flags on attachment: 383301

Committed r252361: <https://trac.webkit.org/changeset/252361>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.