New test failing: css-typedom/attributeStyleMap.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-actual.txt @@ -1,4 +1,4 @@ -PASS test that element.attributeStyleMap exists -PASS test that element.attributeStyleMap has a valid width value +FAIL test that element.attributeStyleMap exists assert_true: expected true got false +FAIL test that element.attributeStyleMap has a valid width value undefined is not an object (evaluating 'el.attributeStyleMap.get')
Same error in imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html. Interestingly, WebKit does not seem to support this feature very well according to the multiplatform expectations, but in this case somehow attributeStyleMap does not even exist, whereas in the general expectations its methods don't exist. --- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt +++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 63: TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined) +CONSOLE MESSAGE: line 63: TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear') -FAIL Untitled TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined) +FAIL Untitled TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear')
I've skipped the css-typedom directory for now, once we enable the feature we have to revisit the tests.
The implementation is tracked in bug 175733. I think we can enable this for GTK/WPE as a experimental feature. The layout test pass after doing so.
Created attachment 381909 [details] Patch
Comment on attachment 381909 [details] Patch Clearing flags on attachment: 381909 Committed r251656: <https://trac.webkit.org/changeset/251656>
All reviewed patches have been landed. Closing bug.