WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED MOVED
189029
[WHLSL] ParseConstexpr is very general
https://bugs.webkit.org/show_bug.cgi?id=189029
Summary
[WHLSL] ParseConstexpr is very general
Myles C. Maxfield
Reported
2018-08-27 16:24:39 PDT
It's called in a few places: vector<float, 4> // that "4" is a constexpr float[10] // that "10" is a constexpr enum asdf : int { XYZ = -3 // that "-3" is a constexpr } switch (foo) { case MyEnum.XYZ: // that "MyEnum.XYZ" is a constexpr } Because of all that, parseConstexpr can return something like operator-((x + y).z) We should do a bunch of filtering to make sure the right kind of constexprs are allowed in the various places where they are allowed.
Attachments
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2018-10-13 15:12:26 PDT
Migrated to
https://github.com/gpuweb/WHLSL/issues/79
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug