Bug 189022 - [WHLSL] ParseTypeArguments calls parseExpression()
Summary: [WHLSL] ParseTypeArguments calls parseExpression()
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2018-08-27 16:05 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:17 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-27 16:05:20 PDT 
It calls parseConstexpr(), which calls parseTerm(), which calls parseExpression(). We don't want to allow things like

int x = 2;
vector<float, (x + 1)> v;

We need to either change how the parser works, or add validation that typeArguments can only be certain things.
Comment 1 Myles C. Maxfield 2018-10-13 15:17:36 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/84