Bug 188873 - [WHLSL] Add more functions to the standard library
Summary: [WHLSL] Add more functions to the standard library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 177645 188489 188685 (view as bug list)
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2018-08-22 17:45 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:25 PDT (History)
6 users (show)

See Also:

Attachments
WIP (182.83 KB, patch)
2018-08-22 17:46 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (217.90 KB, patch)
2018-08-22 19:45 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (225.32 KB, patch)
2018-08-22 22:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Matrix types compile (229.90 KB, patch)
2018-08-23 10:41 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Matrix types compile (229.90 KB, patch)
2018-08-23 10:42 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.61 MB, patch)
2018-08-23 15:45 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (1.61 MB, patch)
2018-08-23 17:35 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (1.61 MB, patch)
2018-08-23 23:17 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.61 MB, patch)
2018-08-24 08:27 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.61 MB, patch)
2018-08-24 16:05 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.61 MB, patch)
2018-08-24 16:28 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (1.61 MB, patch)
2018-08-25 08:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2018-08-25 16:25 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2018-08-25 21:16 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2018-08-26 08:33 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2018-08-27 15:09 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.63 MB, patch)
2018-08-27 15:55 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (222.97 KB, patch)
2018-08-29 10:56 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (222.97 KB, patch)
2018-08-29 11:04 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (17) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-22 17:45:44 PDT 
[WHLSL] Add more functions to the standard library
Comment 1 Myles C. Maxfield 2018-08-22 17:46:25 PDT 
Created attachment 347885 [details]
WIP
Comment 2 Myles C. Maxfield 2018-08-22 19:45:56 PDT 
Created attachment 347895 [details]
WIP
Comment 3 Myles C. Maxfield 2018-08-22 22:34:17 PDT 
Created attachment 347901 [details]
WIP
Comment 4 Myles C. Maxfield 2018-08-23 10:41:43 PDT 
Created attachment 347935 [details]
Matrix types compile
Comment 5 Myles C. Maxfield 2018-08-23 10:42:28 PDT 
Created attachment 347936 [details]
Matrix types compile
Comment 6 Myles C. Maxfield 2018-08-23 15:45:17 PDT 
Created attachment 347963 [details]
Patch
Comment 7 Myles C. Maxfield 2018-08-23 15:48:25 PDT 
*** Bug 188685 has been marked as a duplicate of this bug. ***
Comment 8 Myles C. Maxfield 2018-08-23 17:35:18 PDT 
Created attachment 347980 [details]
WIP
Comment 9 Myles C. Maxfield 2018-08-23 23:17:54 PDT 
Created attachment 347993 [details]
WIP
Comment 10 Myles C. Maxfield 2018-08-24 08:27:56 PDT 
Created attachment 348011 [details]
Patch
Comment 11 Myles C. Maxfield 2018-08-24 16:05:03 PDT 
Created attachment 348051 [details]
Patch
Comment 12 Myles C. Maxfield 2018-08-24 16:28:26 PDT 
Created attachment 348053 [details]
Patch
Comment 13 Myles C. Maxfield 2018-08-25 08:29:32 PDT 
Created attachment 348078 [details]
WIP
Comment 14 Myles C. Maxfield 2018-08-25 16:25:59 PDT 
Created attachment 348087 [details]
Patch
Comment 15 Myles C. Maxfield 2018-08-25 21:16:06 PDT 
Created attachment 348088 [details]
Patch
Comment 16 Myles C. Maxfield 2018-08-26 08:33:17 PDT 
Created attachment 348091 [details]
Patch
Comment 17 Myles C. Maxfield 2018-08-27 15:09:58 PDT 
Created attachment 348208 [details]
Patch
Comment 18 Myles C. Maxfield 2018-08-27 15:55:52 PDT 
Created attachment 348224 [details]
Patch
Comment 19 Filip Pizlo 2018-08-29 07:55:03 PDT 
R=me. I had a hard time setting r+, presumably due to the size of the patch. 

One bit of feedback: you could have written JS code that loops over types and operators to generate the repetitive WHLSL code. Particularly for the swizzle operators.
Comment 20 Myles C. Maxfield 2018-08-29 10:56:09 PDT 
Created attachment 348413 [details]
Patch for committing
Comment 21 Myles C. Maxfield 2018-08-29 10:57:23 PDT 
(In reply to Filip Pizlo from comment #19)
> R=me. I had a hard time setting r+, presumably due to the size of the patch. 
> 
> One bit of feedback: you could have written JS code that loops over types
> and operators to generate the repetitive WHLSL code. Particularly for the
> swizzle operators.

Done. Doing this reduces the patch size from 1.63MB to 222KB.
Comment 22 Myles C. Maxfield 2018-08-29 11:04:31 PDT 
Created attachment 348415 [details]
Patch for committing
Comment 23 WebKit Commit Bot 2018-08-29 11:21:58 PDT 
Comment on attachment 348415 [details]
Patch for committing

Clearing flags on attachment: 348415

Committed r235469: <https://trac.webkit.org/changeset/235469>
Comment 24 WebKit Commit Bot 2018-08-29 11:22:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 25 Radar WebKit Bug Importer 2018-08-29 11:22:48 PDT 
<rdar://problem/43850256>
Comment 26 Myles C. Maxfield 2018-08-29 17:09:30 PDT 
*** Bug 177645 has been marked as a duplicate of this bug. ***
Comment 27 Myles C. Maxfield 2018-08-29 17:24:08 PDT 
*** Bug 188489 has been marked as a duplicate of this bug. ***
Comment 28 Myles C. Maxfield 2018-10-13 15:25:13 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/91