RESOLVED FIXED 188873
[WHLSL] Add more functions to the standard library 
https://bugs.webkit.org/show_bug.cgi?id=188873
Summary [WHLSL] Add more functions to the standard library
Myles C. Maxfield
Reported 2018-08-22 17:45:44 PDT
[WHLSL] Add more functions to the standard library
Attachments
WIP (182.83 KB, patch)
2018-08-22 17:46 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (217.90 KB, patch)
2018-08-22 19:45 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (225.32 KB, patch)
2018-08-22 22:34 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Matrix types compile (229.90 KB, patch)
2018-08-23 10:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Matrix types compile (229.90 KB, patch)
2018-08-23 10:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.61 MB, patch)
2018-08-23 15:45 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (1.61 MB, patch)
2018-08-23 17:35 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (1.61 MB, patch)
2018-08-23 23:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.61 MB, patch)
2018-08-24 08:27 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.61 MB, patch)
2018-08-24 16:05 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.61 MB, patch)
2018-08-24 16:28 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (1.61 MB, patch)
2018-08-25 08:29 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.63 MB, patch)
2018-08-25 16:25 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.63 MB, patch)
2018-08-25 21:16 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.63 MB, patch)
2018-08-26 08:33 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.63 MB, patch)
2018-08-27 15:09 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.63 MB, patch)
2018-08-27 15:55 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (222.97 KB, patch)
2018-08-29 10:56 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (222.97 KB, patch)
2018-08-29 11:04 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-22 17:46:25 PDT
Created attachment 347885 [details] WIP
Myles C. Maxfield
Comment 2 2018-08-22 19:45:56 PDT
Created attachment 347895 [details] WIP
Myles C. Maxfield
Comment 3 2018-08-22 22:34:17 PDT
Created attachment 347901 [details] WIP
Myles C. Maxfield
Comment 4 2018-08-23 10:41:43 PDT
Created attachment 347935 [details] Matrix types compile
Myles C. Maxfield
Comment 5 2018-08-23 10:42:28 PDT
Created attachment 347936 [details] Matrix types compile
Myles C. Maxfield
Comment 6 2018-08-23 15:45:17 PDT
Created attachment 347963 [details] Patch
Myles C. Maxfield
Comment 7 2018-08-23 15:48:25 PDT
*** Bug 188685 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 8 2018-08-23 17:35:18 PDT
Created attachment 347980 [details] WIP
Myles C. Maxfield
Comment 9 2018-08-23 23:17:54 PDT
Created attachment 347993 [details] WIP
Myles C. Maxfield
Comment 10 2018-08-24 08:27:56 PDT
Created attachment 348011 [details] Patch
Myles C. Maxfield
Comment 11 2018-08-24 16:05:03 PDT
Created attachment 348051 [details] Patch
Myles C. Maxfield
Comment 12 2018-08-24 16:28:26 PDT
Created attachment 348053 [details] Patch
Myles C. Maxfield
Comment 13 2018-08-25 08:29:32 PDT
Created attachment 348078 [details] WIP
Myles C. Maxfield
Comment 14 2018-08-25 16:25:59 PDT
Created attachment 348087 [details] Patch
Myles C. Maxfield
Comment 15 2018-08-25 21:16:06 PDT
Created attachment 348088 [details] Patch
Myles C. Maxfield
Comment 16 2018-08-26 08:33:17 PDT
Created attachment 348091 [details] Patch
Myles C. Maxfield
Comment 17 2018-08-27 15:09:58 PDT
Created attachment 348208 [details] Patch
Myles C. Maxfield
Comment 18 2018-08-27 15:55:52 PDT
Created attachment 348224 [details] Patch
Filip Pizlo
Comment 19 2018-08-29 07:55:03 PDT
R=me. I had a hard time setting r+, presumably due to the size of the patch. One bit of feedback: you could have written JS code that loops over types and operators to generate the repetitive WHLSL code. Particularly for the swizzle operators.
Myles C. Maxfield
Comment 20 2018-08-29 10:56:09 PDT
Created attachment 348413 [details] Patch for committing
Myles C. Maxfield
Comment 21 2018-08-29 10:57:23 PDT
(In reply to Filip Pizlo from comment #19) > R=me. I had a hard time setting r+, presumably due to the size of the patch. > > One bit of feedback: you could have written JS code that loops over types > and operators to generate the repetitive WHLSL code. Particularly for the > swizzle operators. Done. Doing this reduces the patch size from 1.63MB to 222KB.
Myles C. Maxfield
Comment 22 2018-08-29 11:04:31 PDT
Created attachment 348415 [details] Patch for committing
WebKit Commit Bot
Comment 23 2018-08-29 11:21:58 PDT
Comment on attachment 348415 [details] Patch for committing Clearing flags on attachment: 348415 Committed r235469: <https://trac.webkit.org/changeset/235469>
WebKit Commit Bot
Comment 24 2018-08-29 11:22:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 25 2018-08-29 11:22:48 PDT
<rdar://problem/43850256>
Myles C. Maxfield
Comment 26 2018-08-29 17:09:30 PDT
*** Bug 177645 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 27 2018-08-29 17:24:08 PDT
*** Bug 188489 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 28 2018-10-13 15:25:13 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/91
Note You need to log in before you can comment on or make changes to this bug.