Bug 188489 - Unary - applied to a variable causes an exception in ConstexprFolder
Summary: Unary - applied to a variable causes an exception in ConstexprFolder
Status: RESOLVED DUPLICATE of bug 188873
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 176199
  Show dependency treegraph
Reported: 2018-08-11 22:03 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:37 PDT (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-11 22:03:19 PDT
visitCallExpression() in ConstexprFolder calls unifyNode() on the argument, which can be a variableRef, which asks the "variable" parameter what its unifyNode() is, but it hasn't been set because we are doing this before the NameResolver or Checker has run.
Comment 1 Myles C. Maxfield 2018-08-11 22:06:53 PDT
Perhaps the solution is not to call unifyNode in ConstexprFolder because the only time we use ConstexprFolder is before the "variable" parameter has been set.
Comment 2 Myles C. Maxfield 2018-08-29 17:24:08 PDT

*** This bug has been marked as a duplicate of bug 188873 ***
Comment 3 Myles C. Maxfield 2018-08-29 17:24:13 PDT
This is done.
Comment 4 Myles C. Maxfield 2018-10-13 15:37:51 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/103