Bug 188514 – WebDriver: handle elements of type file in send keys command

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Carlos Garcia Campos]

https://w3c.github.io/webdriver/#element-send-keys

[Carlos Garcia Campos]

Created attachment 383738 [details]
Patch

[Carlos Garcia Campos]

*** Bug 188513 has been marked as a duplicate of this bug. ***

[EWS Watchlist]

Comment on attachment 383738 [details]
Patch

Attachment 383738 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13264000

New failing tests:
fast/forms/file/file-input-user-selection-events.html

[EWS Watchlist]

Created attachment 383740 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Carlos Garcia Campos]

Ping Brian?

[Carlos Garcia Campos]

I've just realized I submitted the wrong patch here...

[Carlos Garcia Campos]

Created attachment 384330 [details]
Patch

This is the right one

[Carlos Garcia Campos]

Build failures in apple ports would be a matter of exporting symbols I think, I'll submit an updated patch.

[Carlos Garcia Campos]

Created attachment 384403 [details]
Patch

[Blaze Burg]

taking a look.

[Blaze Burg]

Comment on attachment 384403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384403&action=review

r=me

> Source/WebDriver/Session.cpp:1569
> +Session::IsFileUpload Session::parseElementIsFileUploadResult(const RefPtr<JSON::Value>& resultValue)

I would have encoded it as Optional<FileUploadType> and have FileUploadType be one of {Single, Multiple}.

> Source/WebKit/ChangeLog:9
> +        differently, so I'm keeping both to not break safari driver. The new one simply sends the file list ot the web

Typo: ot -> to, safari driver -> safaridriver.

> Source/WebKit/ChangeLog:11
> +        panel, intercept and complete the open panel request and send a dismiss open panel event to the driver.

I don't recall offhand why I didn't pursue an approach like yours. Perhaps it was related to sandboxing not being able to open the file without going through the file chooser path (which grants a sandbox exception for the selected files)?

[Carlos Garcia Campos]

Committed r253030: <https://trac.webkit.org/changeset/253030>

[Radar WebKit Bug Importer]

<rdar://problem/57585779>