Bug 204292 - File input should fire an 'input' event before the 'change' event
Summary: File input should fire an 'input' event before the 'change' event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-18 03:34 PST by Carlos Garcia Campos
Modified: 2019-11-22 05:10 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.90 KB, patch)
2019-11-18 03:39 PST, Carlos Garcia Campos
wenson_hsieh: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews214 for win-future (14.06 MB, application/zip)
2019-11-18 07:16 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews210 for win-future (14.05 MB, application/zip)
2019-11-18 08:25 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Carlos Garcia Campos 2019-11-18 03:39:24 PST
Created attachment 383736 [details]
Patch
Comment 2 EWS Watchlist 2019-11-18 07:16:13 PST
Comment on attachment 383736 [details]
Patch

Attachment 383736 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13264040

New failing tests:
fast/forms/file/file-input-user-selection-events.html
Comment 3 EWS Watchlist 2019-11-18 07:16:16 PST
Created attachment 383744 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Wenson Hsieh 2019-11-18 07:36:22 PST
Comment on attachment 383736 [details]
Patch

We might need to skip the test on Windows, since testRunner.setOpenPanelFiles does not seem to be hooked up to anything there.
Comment 5 EWS Watchlist 2019-11-18 08:25:18 PST
Comment on attachment 383736 [details]
Patch

Attachment 383736 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13264195

New failing tests:
fast/forms/file/file-input-user-selection-events.html
Comment 6 EWS Watchlist 2019-11-18 08:25:20 PST
Created attachment 383750 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 7 Carlos Garcia Campos 2019-11-22 05:09:36 PST
Committed r252768: <https://trac.webkit.org/changeset/252768>
Comment 8 Radar WebKit Bug Importer 2019-11-22 05:10:26 PST
<rdar://problem/57426600>