Bug 188336 – HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

HTML parser should be pushing & popping from the custom element reactions stack:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token

[Ryosuke Niwa]

Created attachment 346607 [details]
Fixes the bug

[Ryosuke Niwa]

Created attachment 346608 [details]
Added a missing change log

[Radar WebKit Bug Importer]

<rdar://problem/42954915>

[Ryosuke Niwa]

Comment on attachment 346608 [details]
Added a missing change log

View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:216
> +            m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData);

Note that the insertion step doesn't need to be split because there is no way to affect the list of open elements in the parser once we forbid document.open/write in the bug 187319.

[Frédéric Wang (:fredw)]

Comment on attachment 346608 [details]
Added a missing change log

View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review

> Source/WebCore/ChangeLog:13
> +        is set or not since the precense of an element queue should not be observable in the case where we're constructing

nit: presence

[Ryosuke Niwa]

Did you mean to r+ the patch with that comment?

[Frédéric Wang (:fredw)]

(In reply to Ryosuke Niwa from comment #6)
> Did you mean to r+ the patch with that comment?

The patch looks good to me, but maybe someone else should review since I worked on this issue in bug 188190.

[Ryosuke Niwa]

(In reply to Frédéric Wang (:fredw) from comment #7)
> (In reply to Ryosuke Niwa from comment #6)
> > Did you mean to r+ the patch with that comment?
> 
> The patch looks good to me, but maybe someone else should review since I
> worked on this issue in bug 188190.

Fair enough although this code change is quite bit different from what you made in that bug.

[Frédéric Wang (:fredw)]

(In reply to Ryosuke Niwa from comment #8)
> (In reply to Frédéric Wang (:fredw) from comment #7)
> > (In reply to Ryosuke Niwa from comment #6)
> > > Did you mean to r+ the patch with that comment?
> > 
> > The patch looks good to me, but maybe someone else should review since I
> > worked on this issue in bug 188190.
> 
> Fair enough although this code change is quite bit different from what you
> made in that bug.

Right, let's take this then.

[Ryosuke Niwa]

Committed r234608: <https://trac.webkit.org/changeset/234608>

[Ryosuke Niwa]

Reopening to attach new patch.

[Ryosuke Niwa]

Created attachment 346728 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 346728 [details]
Patch for landing

Oops, wrong bug.

[Ryosuke Niwa]

Created attachment 346730 [details]
Patch for landing

[Ryosuke Niwa]

Created attachment 346731 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 346731 [details]
Patch for landing

Ugh... wrong bug again.