Bug 186401 – [Mojave] Enable build

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

A few build fixes for the Mojave seed build.

[Jonathan Bedard]

<rdar://problem/39759031>

[Jonathan Bedard]

Created attachment 342197 [details]
Patch

[Alexey Proskuryakov]

PAL/pal/spi/cocoa/QuartzCoreSPI.h:76:35: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400

[Jonathan Bedard]

Created attachment 342207 [details]
Patch

Comment on attachment 342207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342207&action=review

> Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:116
> +SOFT_LINK(DataDetectors, DDResultGetCFTypeID, CFTypeID, (void), ())

This one is kind of surprising. How are we able to successfully call this function when building with an Apple-internal Mojave SDK if we don’t soft-link it?

[Jonathan Bedard]

Created attachment 342286 [details]
Patch

Comment on attachment 342286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342286&action=review

> Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:93
> +CFTypeID DDResultGetCFTypeID(void);

Pretty sure our convention for functions in SPI.h headers is to declare them in a section of the file that’s not guarded with !USE(APPLE_INTERNAL_SDK). This means that when using the internal SDK, we are redeclaring them, which has the advantage of letting us know if our declaration differs from the one in the SDK.

[Jonathan Bedard]

Created attachment 342297 [details]
Patch

Comment on attachment 342297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342297&action=review

> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:76
> +#if PLATFORM(MAC) && !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400

Pretty sure ENABLE(MINIMAL_SIMULATOR) is never true for PLATFORM(MAC).

[Jonathan Bedard]

Comment on attachment 342297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342297&action=review

>> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:76
>> +#if PLATFORM(MAC) && !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> 
> Pretty sure ENABLE(MINIMAL_SIMULATOR) is never true for PLATFORM(MAC).

That does seem to be the case.

Removing ENABLE(MINIMAL_SIMULATOR)

[Jonathan Bedard]

Created attachment 342310 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342310 [details]
Patch

Clearing flags on attachment: 342310

Committed r232642: <https://trac.webkit.org/changeset/232642>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40952654>

[Jonathan Bedard]

Note that as mentioned in <https://bugs.webkit.org/show_bug.cgi?id=18657>, the build will be broken on Seed 1.  This is fixed in seed 2.