Bug 186403 - [webkitpy] Treat svn versions as Version objects
Summary: [webkitpy] Treat svn versions as Version objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 11:53 PDT by Jonathan Bedard
Modified: 2018-06-07 16:15 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2018-06-07 15:43 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-06-07 11:53:34 PDT 
Seems like webkit-patch is generating diffs in a weird way with an svn checkout on Mojave seed 1.  svn-create-patch works just fine, so the root of the problem is somewhere in webkit-patch.
Comment 1 Radar WebKit Bug Importer 2018-06-07 11:57:55 PDT 
<rdar://problem/40904860>
Comment 2 Jonathan Bedard 2018-06-07 15:07:31 PDT 
Looks like there are a few other svn problems in Mojave too, revealed by running 'test-webkitpy --all'.
Comment 3 Jonathan Bedard 2018-06-07 15:43:46 PDT 
Created attachment 342213 [details]
Patch
Comment 4 WebKit Commit Bot 2018-06-07 16:15:47 PDT 
Comment on attachment 342213 [details]
Patch

Clearing flags on attachment: 342213

Committed r232605: <https://trac.webkit.org/changeset/232605>
Comment 5 WebKit Commit Bot 2018-06-07 16:15:48 PDT 
All reviewed patches have been landed.  Closing bug.