Bug 184569 - [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
Summary: [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on...
Status: RESOLVED DUPLICATE of bug 204650
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-12 16:21 PDT by Antoine Quint
Modified: 2019-12-09 01:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (43.90 KB, patch)
2018-04-12 16:34 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.61 MB, application/zip)
2018-04-12 18:01 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (2.99 MB, application/zip)
2018-04-12 18:19 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews205 for win-future (12.63 MB, application/zip)
2018-04-12 19:52 PDT, EWS Watchlist
no flags Details
Patch (47.27 KB, patch)
2018-04-12 23:28 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (48.02 KB, patch)
2018-04-13 00:08 PDT, Antoine Quint
jonlee: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (10.98 MB, application/zip)
2018-04-13 02:12 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews205 for win-future (10.88 MB, application/zip)
2018-04-13 04:01 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-04-12 16:21:37 PDT
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
Comment 1 Antoine Quint 2018-04-12 16:23:17 PDT
<rdar://problem/38671301>
Comment 2 Antoine Quint 2018-04-12 16:34:47 PDT
Created attachment 337849 [details]
Patch
Comment 3 Jon Lee 2018-04-12 16:49:54 PDT
I probably missed it going by, but where do we guarantee the flag is off for the legacy-animation-engine directory?
Comment 4 EWS Watchlist 2018-04-12 18:01:51 PDT
Comment on attachment 337849 [details]
Patch

Attachment 337849 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7299659

New failing tests:
animations/stop-animation-on-suspend.html
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
fast/scrolling/scroll-to-focused-element-asynchronously.html
Comment 5 EWS Watchlist 2018-04-12 18:01:53 PDT
Created attachment 337854 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 EWS Watchlist 2018-04-12 18:19:03 PDT
Comment on attachment 337849 [details]
Patch

Attachment 337849 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7299720

New failing tests:
http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
Comment 7 EWS Watchlist 2018-04-12 18:19:05 PDT
Created attachment 337855 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-04-12 19:51:45 PDT
Comment on attachment 337849 [details]
Patch

Attachment 337849 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7300248

New failing tests:
transitions/zero-duration-with-non-zero-delay-end.html
animations/big-rotation.html
fast/css-generated-content/pseudo-transition.html
animations/animation-direction-alternate-reverse.html
fast/css-generated-content/pseudo-animation.html
Comment 9 EWS Watchlist 2018-04-12 19:52:03 PDT
Created attachment 337858 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 10 Antoine Quint 2018-04-12 22:52:23 PDT
(In reply to Jon Lee from comment #3)
> I probably missed it going by, but where do we guarantee the flag is off for
> the legacy-animation-engine directory?

See the changes in Tools/.
Comment 11 Antoine Quint 2018-04-12 23:11:17 PDT
The Windows results indicate that the flag is off on Windows. Not sure why that is.
Comment 12 Antoine Quint 2018-04-12 23:28:55 PDT
Created attachment 337868 [details]
Patch
Comment 13 Antoine Quint 2018-04-13 00:08:54 PDT
Created attachment 337870 [details]
Patch
Comment 14 EWS Watchlist 2018-04-13 02:12:07 PDT
Comment on attachment 337870 [details]
Patch

Attachment 337870 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7302731

Number of test failures exceeded the failure limit.
Comment 15 EWS Watchlist 2018-04-13 02:12:16 PDT
Created attachment 337876 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 16 EWS Watchlist 2018-04-13 04:00:59 PDT
Comment on attachment 337870 [details]
Patch

Attachment 337870 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7303313

Number of test failures exceeded the failure limit.
Comment 17 EWS Watchlist 2018-04-13 04:01:09 PDT
Created attachment 337877 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 18 Antoine Quint 2018-04-13 09:02:19 PDT
Committed r230632: <https://trac.webkit.org/changeset/230632>
Comment 19 Jonathan Bedard 2018-04-17 16:09:20 PDT
Rolled out in r230736 due to a regression in memory usage: <https://trac.webkit.org/changeset/230736>
Comment 20 Jonathan Bedard 2018-04-17 16:09:48 PDT
Original commit has been rolled out.
Comment 21 Ryan Haddad 2018-04-18 14:27:33 PDT
animations/missing-from-to.html is consistently failing an assertion on WK1 after this rollout:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r230768%20(7281)/results.html
Comment 22 Antoine Quint 2018-04-20 08:15:45 PDT
Before we consider turning the Web Animations flags on by default, we will first turn them on for bots, see https://bugs.webkit.org/show_bug.cgi?id=184819.
Comment 23 Antoine Quint 2019-12-09 01:36:31 PST

*** This bug has been marked as a duplicate of bug 204650 ***