WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 204650
184569
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
https://bugs.webkit.org/show_bug.cgi?id=184569
Summary
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on...
Antoine Quint
Reported
2018-04-12 16:21:37 PDT
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
Attachments
Patch
(43.90 KB, patch)
2018-04-12 16:34 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2
(2.61 MB, application/zip)
2018-04-12 18:01 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews115 for mac-sierra
(2.99 MB, application/zip)
2018-04-12 18:19 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews205 for win-future
(12.63 MB, application/zip)
2018-04-12 19:52 PDT
,
EWS Watchlist
no flags
Details
Patch
(47.27 KB, patch)
2018-04-12 23:28 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(48.02 KB, patch)
2018-04-13 00:08 PDT
,
Antoine Quint
jonlee
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews206 for win-future
(10.98 MB, application/zip)
2018-04-13 02:12 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews205 for win-future
(10.88 MB, application/zip)
2018-04-13 04:01 PDT
,
EWS Watchlist
no flags
Details
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2018-04-12 16:23:17 PDT
<
rdar://problem/38671301
>
Antoine Quint
Comment 2
2018-04-12 16:34:47 PDT
Created
attachment 337849
[details]
Patch
Jon Lee
Comment 3
2018-04-12 16:49:54 PDT
I probably missed it going by, but where do we guarantee the flag is off for the legacy-animation-engine directory?
EWS Watchlist
Comment 4
2018-04-12 18:01:51 PDT
Comment on
attachment 337849
[details]
Patch
Attachment 337849
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/7299659
New failing tests: animations/stop-animation-on-suspend.html fast/animation/css-animation-resuming-when-visible-with-style-change2.html fast/scrolling/scroll-to-focused-element-asynchronously.html
EWS Watchlist
Comment 5
2018-04-12 18:01:53 PDT
Created
attachment 337854
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 6
2018-04-12 18:19:03 PDT
Comment on
attachment 337849
[details]
Patch
Attachment 337849
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/7299720
New failing tests: http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
EWS Watchlist
Comment 7
2018-04-12 18:19:05 PDT
Created
attachment 337855
[details]
Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8
2018-04-12 19:51:45 PDT
Comment on
attachment 337849
[details]
Patch
Attachment 337849
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/7300248
New failing tests: transitions/zero-duration-with-non-zero-delay-end.html animations/big-rotation.html fast/css-generated-content/pseudo-transition.html animations/animation-direction-alternate-reverse.html fast/css-generated-content/pseudo-animation.html
EWS Watchlist
Comment 9
2018-04-12 19:52:03 PDT
Created
attachment 337858
[details]
Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Antoine Quint
Comment 10
2018-04-12 22:52:23 PDT
(In reply to Jon Lee from
comment #3
)
> I probably missed it going by, but where do we guarantee the flag is off for > the legacy-animation-engine directory?
See the changes in Tools/.
Antoine Quint
Comment 11
2018-04-12 23:11:17 PDT
The Windows results indicate that the flag is off on Windows. Not sure why that is.
Antoine Quint
Comment 12
2018-04-12 23:28:55 PDT
Created
attachment 337868
[details]
Patch
Antoine Quint
Comment 13
2018-04-13 00:08:54 PDT
Created
attachment 337870
[details]
Patch
EWS Watchlist
Comment 14
2018-04-13 02:12:07 PDT
Comment on
attachment 337870
[details]
Patch
Attachment 337870
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/7302731
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 15
2018-04-13 02:12:16 PDT
Created
attachment 337876
[details]
Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 16
2018-04-13 04:00:59 PDT
Comment on
attachment 337870
[details]
Patch
Attachment 337870
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/7303313
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 17
2018-04-13 04:01:09 PDT
Created
attachment 337877
[details]
Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Antoine Quint
Comment 18
2018-04-13 09:02:19 PDT
Committed
r230632
: <
https://trac.webkit.org/changeset/230632
>
Jonathan Bedard
Comment 19
2018-04-17 16:09:20 PDT
Rolled out in
r230736
due to a regression in memory usage: <
https://trac.webkit.org/changeset/230736
>
Jonathan Bedard
Comment 20
2018-04-17 16:09:48 PDT
Original commit has been rolled out.
Ryan Haddad
Comment 21
2018-04-18 14:27:33 PDT
animations/missing-from-to.html is consistently failing an assertion on WK1 after this rollout:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r230768%20(7281)/results.html
Antoine Quint
Comment 22
2018-04-20 08:15:45 PDT
Before we consider turning the Web Animations flags on by default, we will first turn them on for bots, see
https://bugs.webkit.org/show_bug.cgi?id=184819
.
Antoine Quint
Comment 23
2019-12-09 01:36:31 PST
*** This bug has been marked as a duplicate of
bug 204650
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug