Bug 184819 – [Web Animations] Turn Web Animations with CSS integration on

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Web Animations] Turn Web Animations with CSS integration on for test runners

[Antoine Quint]

Created attachment 338428 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/39597337>

[Jon Lee]

Comment on attachment 338428 [details]
Patch

r+, but unexpected crash in Mac-debug. Weird unrelated crash on Windows.

[EWS Watchlist]

Comment on attachment 338428 [details]
Patch

Attachment 338428 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7385119

New failing tests:
legacy-animation-engine/compositing/repaint-container-assertion-when-toggling-compositing.html

[EWS Watchlist]

Created attachment 338450 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

The crash happens in a legacy code block, I'm really not sure why and it does not reproduce for me locally on the tests alone. We'll have to either mark those as [ Crash ] or not land this in this state.

[Antoine Quint]

Created attachment 338480 [details]
Patch

[EWS Watchlist]

Comment on attachment 338480 [details]
Patch

Attachment 338480 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7392701

New failing tests:
legacy-animation-engine/transitions/background-position-transitions.html

[EWS Watchlist]

Created attachment 338517 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 340308 [details]
Patch

[EWS Watchlist]

Comment on attachment 340308 [details]
Patch

Attachment 340308 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7677335

New failing tests:
animations/added-while-suspended.html

[EWS Watchlist]

Created attachment 340315 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 340335 [details]
Patch

[EWS Watchlist]

Comment on attachment 340335 [details]
Patch

Attachment 340335 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7679949

New failing tests:
animations/added-while-suspended.html
transitions/created-while-suspended.html

[EWS Watchlist]

Created attachment 340345 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Going to deal with the experimental feature separately in https://bugs.webkit.org/show_bug.cgi?id=185647.

[Antoine Quint]

Created attachment 340407 [details]
Patch

[EWS Watchlist]

Comment on attachment 340407 [details]
Patch

Attachment 340407 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7688794

New failing tests:
animations/added-while-suspended.html
transitions/created-while-suspended.html

[EWS Watchlist]

Created attachment 340409 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340407 [details]
Patch

Attachment 340407 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7689869

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 340420 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antoine Quint]

Created attachment 340427 [details]
Patch

[EWS Watchlist]

Comment on attachment 340427 [details]
Patch

Attachment 340427 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7691265

New failing tests:
animations/added-while-suspended.html

[EWS Watchlist]

Created attachment 340432 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 340478 [details]
Patch

[EWS Watchlist]

Comment on attachment 340478 [details]
Patch

Attachment 340478 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7697470

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html

[EWS Watchlist]

Created attachment 340486 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 340478 [details]
Patch

Attachment 340478 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7697696

New failing tests:
animations/added-while-suspended.html
transitions/created-while-suspended.html

[EWS Watchlist]

Created attachment 340487 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Committed r231851: <https://trac.webkit.org/changeset/231851>

[Antoine Quint]

This was closed by mistake, r231851 was for https://bugs.webkit.org/show_bug.cgi?id=185299.

[Antoine Quint]

Reopening.

[Antoine Quint]

Created attachment 340581 [details]
Patch

[EWS Watchlist]

Comment on attachment 340581 [details]
Patch

Attachment 340581 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7709583

New failing tests:
animations/added-while-suspended.html

[EWS Watchlist]

Created attachment 340586 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Committed r231948: <https://trac.webkit.org/changeset/231948>

[Antoine Quint]

Committed r231977: <https://trac.webkit.org/changeset/231977>

[Antoine Quint]

Reverted in r231977.

[Antoine Quint]

Created attachment 341276 [details]
Patch

[EWS Watchlist]

Comment on attachment 341276 [details]
Patch

Attachment 341276 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7799613

New failing tests:
animations/fill-mode-removed.html

[EWS Watchlist]

Created attachment 341283 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341276 [details]
Patch

Attachment 341276 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7799702

New failing tests:
animations/fill-mode-removed.html

[EWS Watchlist]

Created attachment 341286 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341276 [details]
Patch

Attachment 341276 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7799723

New failing tests:
animations/fill-mode-removed.html

[EWS Watchlist]

Created attachment 341288 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 341276 [details]
Patch

Attachment 341276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7802460

New failing tests:
animations/added-while-suspended.html
animations/fill-mode-removed.html

[EWS Watchlist]

Created attachment 341321 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 341276 [details]
Patch

Attachment 341276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7803015

New failing tests:
animations/added-while-suspended.html
animations/fill-mode-removed.html

[EWS Watchlist]

Created attachment 341327 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 350754 [details]
EWS run, not for review

[Dean Jackson]

Comment on attachment 350754 [details]
EWS run, not for review

looks good

[EWS Watchlist]

Attachment 350754 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1759:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1763:  Path does not exist.  [test/expectations] [5]
Total errors found: 3 in 204 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 350754 [details]
EWS run, not for review

Attachment 350754 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9345144

New failing tests:
imported/w3c/web-platform-tests/css/css-logical/animation-003.tentative.html
imported/w3c/web-platform-tests/css/css-scoping/keyframes-001.html

[EWS Watchlist]

Created attachment 350764 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350754 [details]
EWS run, not for review

Attachment 350754 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9345163

New failing tests:
imported/w3c/web-platform-tests/css/css-logical/animation-003.tentative.html
imported/w3c/web-platform-tests/css/css-scoping/keyframes-001.html

[EWS Watchlist]

Created attachment 350767 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Antoine Quint]

Created attachment 350768 [details]
EWS run, not for review

[EWS Watchlist]

Attachment 350768 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1759:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1763:  Path does not exist.  [test/expectations] [5]
Total errors found: 3 in 204 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 350768 [details]
EWS run, not for review

Attachment 350768 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9346772

New failing tests:
animations/stop-animation-on-suspend.html

[EWS Watchlist]

Created attachment 350786 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 350768 [details]
EWS run, not for review

Attachment 350768 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9347163

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350789 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antoine Quint]

Created attachment 350858 [details]
Patch for EWS run, not for review

[EWS Watchlist]

Attachment 350858 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1759:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:1763:  Path does not exist.  [test/expectations] [5]
Total errors found: 3 in 206 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 350858 [details]
Patch for EWS run, not for review

Attachment 350858 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9356313

New failing tests:
legacy-animation-engine/transitions/transition-hit-test.html
transitions/clip-path-transitions.html
legacy-animation-engine/transitions/transition-hit-test-transform.html
legacy-animation-engine/animations/stacking-context-unchanged-while-running.html
css3/filters/composited-during-animation-layertree.html

[EWS Watchlist]

Created attachment 350863 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 350858 [details]
Patch for EWS run, not for review

Attachment 350858 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9356003

New failing tests:
legacy-animation-engine/transitions/transition-hit-test.html
transitions/clip-path-transitions.html
legacy-animation-engine/transitions/transition-hit-test-transform.html
legacy-animation-engine/animations/stacking-context-unchanged-while-running.html
css3/filters/composited-during-animation-layertree.html

[EWS Watchlist]

Created attachment 350865 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antoine Quint]

Fallout from these changes are tracked in webkit.org/b/190032.

[Antoine Quint]

Committed r236541: <https://trac.webkit.org/changeset/236541>