Bug 182573 - Improve NetworkResourceLoader logging to capture redirect cases
Summary: Improve NetworkResourceLoader logging to capture redirect cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-07 09:26 PST by Brent Fulgham
Modified: 2018-02-07 14:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2018-02-07 09:55 PST, Brent Fulgham 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-02-07 09:26:43 PST 
The logging updates in Bug 182455 did not catch redirects, which should be logged, too.
Comment 1 Radar WebKit Bug Importer 2018-02-07 09:50:33 PST 
<rdar://problem/37316714>
Comment 2 Brent Fulgham 2018-02-07 09:55:41 PST 
Created attachment 333299 [details]
Patch
Comment 3 Chris Dumez 2018-02-07 13:46:10 PST 
Comment on attachment 333299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34
> +#import "NetworkResourceLoader.h"

I am unclear why this import is needed.
Comment 4 Brent Fulgham 2018-02-07 13:53:06 PST 
Comment on attachment 333299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review

>> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34
>> +#import "NetworkResourceLoader.h"
> 
> I am unclear why this import is needed.

Oh! You are right. I added that by mistake. I'll remove it.
Comment 5 John Wilander 2018-02-07 13:58:32 PST 
Just a heads up: You might have to merge since I recently landed https://bugs.webkit.org/show_bug.cgi?id=182559 that touches this code.
Comment 6 Brent Fulgham 2018-02-07 14:53:37 PST 
Committed r228244: <https://trac.webkit.org/changeset/228244>