Bug 182455 - Improve NetworkResourceLoader logging so it can be used for 'setCookiesFromDOM'
Summary: Improve NetworkResourceLoader logging so it can be used for 'setCookiesFromDOM'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-02 16:53 PST by Brent Fulgham
Modified: 2018-02-05 12:03 PST (History)
5 users (show)

See Also:


Attachments
Patch (16.53 KB, patch)
2018-02-02 17:14 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (18.58 KB, patch)
2018-02-05 10:29 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch for landing (18.74 KB, patch)
2018-02-05 10:41 PST, Brent Fulgham
bfulgham: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-02-02 16:53:03 PST
The diagnostic logging code handles cookies set by resource loads, but it doesn't log activity generated in script.

This patch revises the NetworkResourceLoader logging code so that it can be used for the 'setCookiesFromDOM' case.
Comment 1 Brent Fulgham 2018-02-02 16:53:25 PST
<rdar://problem/36626601>
Comment 2 Brent Fulgham 2018-02-02 17:14:27 PST
Created attachment 333020 [details]
Patch
Comment 3 Brent Fulgham 2018-02-05 10:29:12 PST
Created attachment 333093 [details]
Patch
Comment 4 Chris Dumez 2018-02-05 10:32:57 PST
Comment on attachment 333093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review

r=me with comment

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713
> +bool NetworkResourceLoader::shouldLogCookieInformation()

Why did you drop the const? Seems like a method that should be const.
Comment 5 Brent Fulgham 2018-02-05 10:41:25 PST
Created attachment 333095 [details]
Patch for landing
Comment 6 Brent Fulgham 2018-02-05 10:42:02 PST
Comment on attachment 333093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713
>> +bool NetworkResourceLoader::shouldLogCookieInformation()
> 
> Why did you drop the const? Seems like a method that should be const.

I made this a static method on the object, so it cannot be const anymore.
Comment 7 Brent Fulgham 2018-02-05 10:42:34 PST
Note: The patch failed to build on iOS because the new logging was not guarded by the RELEASE_LOG_DISABLED macro. I've fixed that in the patch for landing.
Comment 8 Brent Fulgham 2018-02-05 12:03:50 PST
Committed r228111: <https://trac.webkit.org/changeset/228111>