Bug 182230 - [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
Summary: [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/He...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 182053 182241 182287
Blocks: 5991 161612 182289 182290
  Show dependency treegraph
 
Reported: 2018-01-28 23:22 PST by Frédéric Wang (:fredw)
Modified: 2018-07-11 06:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (WIP) (24.35 KB, patch)
2018-01-28 23:29 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
182053+182230 for EWS (46.97 KB, patch)
2018-01-28 23:30 PST, Frédéric Wang (:fredw)
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.03 MB, application/zip)
2018-01-29 00:44 PST, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.51 MB, application/zip)
2018-01-29 01:07 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-sierra (3.34 MB, application/zip)
2018-01-29 01:24 PST, Build Bot
no flags Details
Archive of layout-test-results from ews102 for mac-sierra (2.70 MB, application/zip)
2018-01-29 02:32 PST, Build Bot
no flags Details
Patch (182053+182230+182241) for EWS (83.18 KB, patch)
2018-01-30 03:23 PST, Frédéric Wang (:fredw)
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.17 MB, application/zip)
2018-01-30 05:02 PST, Build Bot
no flags Details
Patch (47.89 KB, patch)
2018-01-30 08:00 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (182053+182287+182230) for EWS (69.95 KB, patch)
2018-02-01 01:27 PST, Frédéric Wang (:fredw)
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip)
2018-02-01 02:49 PST, Build Bot
no flags Details
Patch (48.06 KB, patch)
2018-02-01 07:00 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (applies on top of 182053) (48.09 KB, patch)
2018-05-10 02:06 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (applies on top of 182053) (48.12 KB, patch)
2018-07-10 07:42 PDT, Frédéric Wang (:fredw)
fred.wang: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-01-28 23:22:44 PST
.
Comment 1 Frédéric Wang (:fredw) 2018-01-28 23:29:13 PST
Created attachment 332512 [details]
Patch (WIP)
Comment 2 Frédéric Wang (:fredw) 2018-01-28 23:30:11 PST
Created attachment 332513 [details]
182053+182230 for EWS
Comment 3 Build Bot 2018-01-28 23:31:54 PST
Attachment 332513 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Element.cpp:56:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2018-01-29 00:44:24 PST
Comment on attachment 332513 [details]
182053+182230 for EWS

Attachment 332513 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6246447

New failing tests:
tiled-drawing/scrolling/frames/fixed-inside-frame.html
tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html
http/tests/navigation/anchor-frames.html
fast/dom/window-scroll-scaling.html
fast/multicol/scrolling-overflow.html
fast/dom/Element/body-scrollLeft.html
fast/dom/Element/documentElement-scrollTop.html
http/tests/navigation/anchor-frames-gbk.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html
fast/dom/Element/scrollTop.html
fast/scrolling/latching/scroll-div-no-latching.html
fast/dom/Element/body-scrollTop.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scrollLeft.html
tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html
fast/scrolling/latching/scroll-nested-iframe.html
fast/dom/Element/scrolling-funtions-on-body.html
tiled-drawing/scrolling/iframe_in_iframe.html
fast/dom/Element/documentElement-scrollLeft.html
fast/scrolling/latching/iframe_in_iframe.html
fast/scrolling/latching/scroll-latched-nested-div.html
Comment 5 Build Bot 2018-01-29 00:44:25 PST
Created attachment 332516 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Build Bot 2018-01-29 01:07:35 PST
Comment on attachment 332513 [details]
182053+182230 for EWS

Attachment 332513 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6246462

New failing tests:
fast/dom/Element/scrollLeft.html
fast/multicol/scrolling-overflow.html
fast/dom/Element/body-scrollLeft.html
platform/ios/ios/fast/coordinates/page-offsets.html
fast/dom/Element/documentElement-scrollTop.html
fast/dom/Element/scrollTop.html
fast/dom/Element/body-scrollTop.html
fast/dom/Element/scrolling-funtions-on-body.html
imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html
fast/dom/Element/documentElement-scrollLeft.html
Comment 7 Build Bot 2018-01-29 01:07:37 PST
Created attachment 332519 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 8 Build Bot 2018-01-29 01:24:53 PST
Comment on attachment 332513 [details]
182053+182230 for EWS

Attachment 332513 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6246483

New failing tests:
http/tests/navigation/anchor-frames-same-origin.html
http/tests/navigation/anchor-frames.html
fast/dom/window-scroll-scaling.html
fast/multicol/scrolling-overflow.html
fast/dom/Element/body-scrollLeft.html
fast/dom/Element/documentElement-scrollTop.html
http/tests/navigation/anchor-frames-gbk.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html
fast/scrolling/latching/scroll-div-no-latching.html
fast/dom/Element/body-scrollTop.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scrollLeft.html
fast/scrolling/latching/scroll-nested-iframe.html
fast/dom/Element/scrolling-funtions-on-body.html
fast/dom/Element/scrollTop.html
fast/dom/Element/documentElement-scrollLeft.html
fast/scrolling/latching/iframe_in_iframe.html
fast/scrolling/latching/scroll-latched-nested-div.html
Comment 9 Build Bot 2018-01-29 01:24:55 PST
Created attachment 332520 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 Build Bot 2018-01-29 02:32:08 PST
Comment on attachment 332513 [details]
182053+182230 for EWS

Attachment 332513 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6247288

New failing tests:
http/tests/navigation/anchor-frames-same-origin.html
http/tests/navigation/anchor-frames.html
fast/dom/window-scroll-scaling.html
fast/multicol/scrolling-overflow.html
fast/dom/Element/body-scrollLeft.html
fast/dom/Element/documentElement-scrollTop.html
http/tests/navigation/anchor-frames-gbk.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html
fast/scrolling/latching/scroll-div-no-latching.html
fast/dom/Element/body-scrollTop.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scrollLeft.html
fast/scrolling/latching/scroll-nested-iframe.html
fast/dom/Element/scrolling-funtions-on-body.html
fast/dom/Element/scrollTop.html
fast/dom/Element/documentElement-scrollLeft.html
fast/scrolling/latching/iframe_in_iframe.html
fast/scrolling/latching/scroll-latched-nested-div.html
Comment 11 Build Bot 2018-01-29 02:32:09 PST
Created attachment 332529 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Frédéric Wang (:fredw) 2018-01-30 03:23:44 PST
Created attachment 332645 [details]
Patch (182053+182230+182241) for EWS
Comment 13 Build Bot 2018-01-30 05:02:45 PST
Comment on attachment 332645 [details]
Patch (182053+182230+182241) for EWS

Attachment 332645 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6259872

New failing tests:
imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html
Comment 14 Build Bot 2018-01-30 05:02:46 PST
Created attachment 332650 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 15 Frédéric Wang (:fredw) 2018-01-30 08:00:28 PST
Created attachment 332653 [details]
Patch

This patch applies after the dependencies.
Comment 16 Frédéric Wang (:fredw) 2018-01-31 03:13:11 PST
Comment on attachment 332653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332653&action=review

> LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html:21
> +        internals.settings.setCSSOMViewScrollingAPIEnabled(false);

This does not work well. I handled it better in bug 182287 instead.
Comment 17 Frédéric Wang (:fredw) 2018-02-01 01:27:47 PST
Created attachment 332857 [details]
Patch (182053+182287+182230) for EWS

Rebasing over bug 182287.
Comment 18 Build Bot 2018-02-01 02:49:00 PST
Comment on attachment 332857 [details]
Patch (182053+182287+182230) for EWS

Attachment 332857 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6313714

New failing tests:
tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html
Comment 19 Build Bot 2018-02-01 02:49:02 PST
Created attachment 332864 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 20 Frédéric Wang (:fredw) 2018-02-01 07:00:46 PST
Created attachment 332874 [details]
Patch
Comment 21 Frédéric Wang (:fredw) 2018-05-10 02:06:18 PDT
Created attachment 340079 [details]
Patch (applies on top of 182053)

Rebasing...
Comment 22 Frédéric Wang (:fredw) 2018-07-10 07:42:57 PDT
Created attachment 344695 [details]
Patch (applies on top of 182053)

Rebasing...